nkalmar commented on a change in pull request #925: ZOOKEEPER-3372 Cleanup
pom.xml in order to let Maven clients import as few dependencies as possible
URL: https://github.com/apache/zookeeper/pull/925#discussion_r279190560
##########
File path: zookeeper-assembly/src/main/assembly/bin-package.xml
##########
@@ -29,29 +29,23 @@
<componentDescriptor>src/main/assembly/components.xml</componentDescriptor>
</componentDescriptors>
- <moduleSets>
- <!-- ZooKeeper jars (excluding pom projects) including 3rd party
dependencies -->
- <moduleSet>
- <useAllReactorProjects>true</useAllReactorProjects>
+ <dependencySets>
+ <dependencySet>
<includes>
- <include>org.apache.zookeeper:zookeeper</include>
+ <include>*:*</include>
</includes>
-
- <binaries>
- <outputDirectory>lib</outputDirectory>
- <unpack>false</unpack>
- <dependencySets>
- <dependencySet>
- <excludes>
- <exclude>org.apache.zookeeper:zookeeper-recipes</exclude>
- <exclude>org.apache.zookeeper:zookeeper-client</exclude>
- <exclude>org.apache.zookeeper:zookeeper-docs</exclude>
- </excludes>
- </dependencySet>
- </dependencySets>
- </binaries>
- </moduleSet>
- </moduleSets>
+ <excludes>
+ <exclude>org.apache.zookeeper:zookeeper-recipes</exclude>
Review comment:
With the changes in the bin-package I get a warning when building teh
tarball:
"Cannot include project artifact:
org.apache.zookeeper:zookeeper-assembly:pom:3.6.0-SNAPSHOT; it doesn't have an
associated file or directory."
What was the reason to change moduleSets to dependencySets?
Also a super-nit: excludes have 3 space indents here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
