anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi
version of getChildren request
URL: https://github.com/apache/zookeeper/pull/929#discussion_r281146207
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
##########
@@ -964,7 +974,9 @@ public ProcessTxnResult processTxn(TxnHeader header,
Record txn, boolean isSubTx
ByteBufferInputStream.byteBuffer2Record(bb, record);
- if (failed && subtxn.getType() != OpCode.error){
+ if (failed && subtxn.getType() != OpCode.error &&
+ // Before the error, the return values of getter
methods are valid.
Review comment:
Please add more details to the comments, because it's hard to understand the
intention here. Something like:
> For `getChildren` requests we'd like to the see the results of requests
which was made before the error in the multi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
