anmolnar commented on issue #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#issuecomment-490754714 Got it. The counter of processed requested (cnt_)PREP_PROCESS_TIME is updated in the `run()` method _after_ `pRequest()`. `pRequest()` calls nextRequestProcessor.process() which is mocked to update the latch for synchronization. As a consequence the test could end before the counter is updated. To fix this I suggest to move the update of the counter inside the pRequest() call before `nextRequestProcessor.process(). It will be more accurate anyway.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
