lvfangmin commented on a change in pull request #918: ZOOKEEPER-3366: Pluggable
metrics system for ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#discussion_r283073478
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -1383,4 +1392,85 @@ public void setResponseCachingEnabled(boolean
isEnabled) {
public ResponseCache getReadResponseCache() {
return isResponseCachingEnabled ? readResponseCache : null;
}
+
+ protected void registerMetrics() {
Review comment:
That makes sense to me, are we seeing this pattern often, should we define
an interface for these methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
