Oh, I think I got it now. I removed them from the ‘website’ branch, but haven’t published the changes to ‘asf-site’.
Pat, if you go ahead with your changes, remove them from the site. Otherwise I’ll do it anyway with the 3.5 release today/tomorrow. Andor > On 2019. May 20., at 13:06, Enrico Olivelli <[email protected]> wrote: > > Andor, > my links are from "current" asf-site on github, so files are there > https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13 > > Enrico > > Il giorno lun 20 mag 2019 alle ore 13:04 Andor Molnar <[email protected]> ha > scritto: > >> Hi Pat, >> >> Are you at latest commit on ‘website’ branch? >> I removed these files in commit 98472b8b793d10f011ecb79b9acc9b6b07574f5c. >> >> I agree that binaries probably have been added to the repo by mistake. >> >> Regards, >> Andor >> >> >> >>> On 2019. May 19., at 21:12, Enrico Olivelli <[email protected]> wrote: >>> >>> Il dom 19 mag 2019, 20:41 Patrick Hunt <[email protected]> ha scritto: >>> >>>> In looking at the older versions under content they don't include that >>>> file. Probably an un-intended side effect of the recent >>>> changes/improvements around the docs/site. I'd say we should remove >> them. >>>> Can you check, I assume there are no links to that file (locally)? >>>> >>> >>> Sure. >>> Anyway we are on git so we can always use 'git revert' :) >>> >>> Enrico >>> >>> >>> >>>> Patrick >>>> >>>> On Sat, May 18, 2019 at 11:58 PM Enrico Olivelli <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> While trying to push a new version of the website >>>>> I was following the guide here [1] >>>>> >>>>> But if I build the website locally I get this report from git status >>>>> >>>>> deleted: content/doc/r3.4.12/zookeeper-3.4.12.tar.gz >>>>> deleted: content/doc/r3.4.13/zookeeper-3.4.13.tar.gz >>>>> >>>>> It seems that if I commit the whole image of the built website I would >>>> drop >>>>> these tgz files. (you can see those files at [2] and [3]) >>>>> IMHO those binaries shouldn't be hosted on the website and we should >>>> remove >>>>> them. >>>>> I will remove them if we agree >>>>> >>>>> Cheers >>>>> Enrico >>>>> >>>>> [1] https://cwiki.apache.org/confluence/display/ZOOKEEPER/WebSiteSetup >>>>> [2] >>>> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13 >>>>> [3] >>>> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.12 >>>>> >>>> >> >>
