Il giorno dom 23 giu 2019 alle ore 00:12 Enrico Olivelli < [email protected]> ha scritto:
> > > Il giorno dom 23 giu 2019 alle ore 00:11 Enrico Olivelli < > [email protected]> ha scritto: > >> >> >> Il giorno sab 22 giu 2019 alle ore 23:16 Andor Molnar <[email protected]> >> ha scritto: >> >>> When are the Maven-based trunk jobs going be available? >>> >> >> Doing it now >> > > Anyway we already have the maven build of master, I only have to create > all the jobs for all supported jdks, for owasp.... > I have created jobs for master on linux and jdk8,11 and 12 + a job for owasp But they are currently failing due to a small problem with apache-rat:check this is the (trivial) fix and the activation of apache-rat:check on Travis This is my patch but is currently work in progress (it is failing on Travis, I will continue the work as soon as possible) https://github.com/apache/zookeeper/pull/998 Enrico > Enrico > > >> >> >>> I’m not sure disabling the precommit job was a good idea until we have a >>> working dashboard of Maven builds. >>> >>> Andor >>> >>> >>> >>> > On 2019. Jun 22., at 23:10, Andor Molnar <[email protected]> wrote: >>> > >>> > Done. >>> > Ant PreCommit does not run on master anymore. >>> > >>> > Andor >>> > >>> > >>> > >>> > >>> >> On 2019. Jun 20., at 20:22, Enrico Olivelli <[email protected]> >>> wrote: >>> >> >>> >> Il giorno mer 19 giu 2019 alle ore 22:56 Andor Molnar < >>> [email protected]> ha >>> >> scritto: >>> >> >>> >>> "I also having problem in disabling the ant precommit only for >>> master” >>> >>> >>> >>> I see branch-3.4 and branch-3.5 in Whitelist Target Branches. >>> >>> What about adding ‘master’ to Blacklist Target Branches? >>> >>> >>> >> >>> >> I will try, currently Jenkins is down (503 http status code). >>> >> If you can, Andor, please change it. >>> >> I will do as soon as I have time and jenkins is up and running >>> >> >>> >> Thanks for the suggestion >>> >> >>> >> Enrico >>> >> >>> >> >>> >> >>> >>> >>> >>> Andor >>> >>> >>> >>> >>> >>> >>> >>>> On 2019. Jun 18., at 20:51, Enrico Olivelli <[email protected]> >>> wrote: >>> >>>> >>> >>>> Il dom 16 giu 2019, 18:18 Andor Molnar <[email protected]> ha >>> scritto: >>> >>>> >>> >>>>> I created a new view for Maven builds: >>> >>>>> >>> >>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper-Maven/ < >>> >>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper-Maven/> >>> >>>>> >>> >>>>> Where are the rest? >>> >>>>> Maybe I’m looking at the wrong place, but cannot find anything >>> else. >>> >>>>> >>> >>>> >>> >>>> I will create the new jobs for maven and once they work I will >>> disable >>> >>> the >>> >>>> old ones. >>> >>>> >>> >>>> I also having problem in disabling the ant precommit only for >>> master >>> >>>> >>> >>>> >>> >>>> >>> >>>>> Andor >>> >>>>> >>> >>>>> >>> >>>>> >>> >>>>>> On 2019. Jun 14., at 9:39, Enrico Olivelli <[email protected]> >>> >>> wrote: >>> >>>>>> >>> >>>>>> Il ven 14 giu 2019, 09:17 Andor Molnar <[email protected]> >>> ha >>> >>>>>> scritto: >>> >>>>>> >>> >>>>>>> +1 for dropping it. >>> >>>>>>> >>> >>>>>>> Enrico, have you created a Jenkins view which gathers all Maven >>> based >>> >>>>>>> builds? >>> >>>>>>> >>> >>>>>> >>> >>>>>> No I don't. I am not an user of such views. >>> >>>>>> Feel free to do it. >>> >>>>>> >>> >>>>>> We should also drop a bunch of disabled jobs, like the one for >>> solaris >>> >>>>>> >>> >>>>>> We should create a wiki page with the description of every job >>> >>>>>> >>> >>>>>> Enrico >>> >>>>>> >>> >>>>>> >>> >>>>>>> Andor >>> >>>>>>> >>> >>>>>>> >>> >>>>>>> >>> >>>>>>> On Fri, Jun 14, 2019 at 7:44 AM Enrico Olivelli < >>> [email protected]> >>> >>>>>>> wrote: >>> >>>>>>> >>> >>>>>>>> Il ven 14 giu 2019, 00:50 Michael Han <[email protected]> ha >>> scritto: >>> >>>>>>>> >>> >>>>>>>>> I see now. This was a job I set up long time ago for my own >>> testing >>> >>>>>>>> purpose >>> >>>>>>>>> only; it was not intended to be part of official commit >>> workflow. I >>> >>> am >>> >>>>>>>> not >>> >>>>>>>>> sure how this job becomes the official post commit job though. >>> If we >>> >>>>>>> have >>> >>>>>>>>> daily builds (do we) - then probably we don't need this. >>> Though keep >>> >>>>> it >>> >>>>>>>>> does not hurt, either. >>> >>>>>>>> >>> >>>>>>>> >>> >>>>>>>> Actually it is the last tool that is using ant and it is the >>> only one >>> >>>>>>> that >>> >>>>>>>> needs jira credentials. >>> >>>>>>>> >>> >>>>>>>> Personally I would drop it. >>> >>>>>>>> >>> >>>>>>>> Enrico >>> >>>>>>>> >>> >>>>>>>> >>> >>>>>>>> I have no strong preference one way or the other. >>> >>>>>>>>> >>> >>>>>>>>> >>> >>>>>>>>> On Wed, Jun 12, 2019 at 1:50 AM Andor Molnar >>> >>>>>>> <[email protected] >>> >>>>>>>>> >>> >>>>>>>>> wrote: >>> >>>>>>>>> >>> >>>>>>>>>> It might give some additional feedback to the >>> committer/contributor >>> >>>>>>>>> whether >>> >>>>>>>>>> the patch has been successfully integrated into the target >>> branch. >>> >>>>>>>> We've >>> >>>>>>>>>> seen issues when the merge build was outdated, showing green >>> light >>> >>> on >>> >>>>>>>> the >>> >>>>>>>>>> pull request and the commit eventually broke master after >>> merging. >>> >>>>>>>>>> >>> >>>>>>>>>> I'm not 100% sure we need it, maybe other folks can give some >>> more >>> >>>>>>>> color >>> >>>>>>>>> to >>> >>>>>>>>>> this. >>> >>>>>>>>>> >>> >>>>>>>>>> Btw. do we already have a View in jenkins for Maven builds >>> like >>> >>> this >>> >>>>>>>> one >>> >>>>>>>>>> for Ant: https://builds.apache.org/view/S-Z/view/ZooKeeper/ >>> >>>>>>>>>> >>> >>>>>>>>>> Andor >>> >>>>>>>>>> >>> >>>>>>>>>> >>> >>>>>>>>>> >>> >>>>>>>>>> On Wed, Jun 12, 2019 at 10:33 AM Enrico Olivelli < >>> >>>>>>> [email protected]> >>> >>>>>>>>>> wrote: >>> >>>>>>>>>> >>> >>>>>>>>>>> Michael >>> >>>>>>>>>>> it seems that the job is trying to send emails to you at >>> >>>>>>>>>> [email protected] >>> >>>>>>>>>>> but there is a typo. >>> >>>>>>>>>>> >>> >>>>>>>>>>> Do we still need this job? >>> >>>>>>>>>>> As we are dropping ANT we have to migrate it, but I don't >>> find >>> >>> much >>> >>>>>>>>> value >>> >>>>>>>>>>> as we are already performing daily builds and precommits. >>> >>>>>>>>>>> Having such comment in jira is not so important >>> >>>>>>>>>>> >>> >>>>>>>>>>> Enrico >>> >>>>>>>>>>> >>> >>>>>>>>>>> Enrico >>> >>>>>>>>>>> >>> >>>>>>>>>>> Il mer 12 giu 2019, 10:04 Enrico Olivelli < >>> [email protected]> >>> >>> ha >>> >>>>>>>>>>> scritto: >>> >>>>>>>>>>> >>> >>>>>>>>>>>> Self answered from the message on jira... >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> It is zookeeper-trunk-single-thread >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> Thanks Michael >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> Enrico >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> SUCCESS: Integrated in Jenkins build >>> >>>>>>> Zookeeper-trunk-single-thread >>> >>>>>>>>> #388 >>> >>>>>>>>>>>> (See [ >>> >>>>>>>>> >>> https://builds.apache.org/job/Zookeeper-trunk-single-thread/388/ >>> >>>>>>>>>> ]) >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - >>> move >>> >>>>>>>>> remaining >>> >>>>>>>>>>>> (nkalmar: rev 6af151a7e44760c33165e58d3b33a4d2760283a4) >>> >>>>>>>>>>>> * (edit) >>> >>>>>>>> zookeeper-server/src/main/java/org/apache/zookeeper/metrics/ >>> >>>>>>>>>>>> MetricsContext.java >>> >>>>>>>>>>>> * (edit) >>> >>>>>>>> zookeeper-server/src/main/java/org/apache/zookeeper/server/ >>> >>>>>>>>>>>> command/MonitorCommand.java >>> >>>>>>>>>>>> * (edit) >>> >>>>>>>> zookeeper-server/src/main/java/org/apache/zookeeper/server/ >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> Il mer 12 giu 2019, 02:00 Michael Han <[email protected]> ha >>> >>>>>>>> scritto: >>> >>>>>>>>>>>> >>> >>>>>>>>>>>>> Hi Enrico, >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>> I don't think it's a post commit job that adds the "Issue >>> >>>>>>> resolved >>> >>>>>>>>> by >>> >>>>>>>>>>> pull >>> >>>>>>>>>>>>> request...." comment (if this is the comment you were >>> referring >>> >>>>>>>>> to.). >>> >>>>>>>>>>> This >>> >>>>>>>>>>>>> was added by the merge script through JIRA api. >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>> On Mon, Jun 10, 2019 at 1:34 PM Enrico Olivelli < >>> >>>>>>>>> [email protected]> >>> >>>>>>>>>>>>> wrote: >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>>> Hi ZooKeepers, >>> >>>>>>>>>>>>>> I am looking for the Post-Commit job, the one that adds >>> that >>> >>>>>>>> JIRA >>> >>>>>>>>>>>>> comment >>> >>>>>>>>>>>>>> after we merge a PR. >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> I would like to understand it and decide whether to drop >>> it or >>> >>>>>>>> to >>> >>>>>>>>>> move >>> >>>>>>>>>>>>> it >>> >>>>>>>>>>>>>> to Maven. >>> >>>>>>>>>>>>>> Personally I don't find much value in that task. >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> This is my search [1] (I hope that the link works for you) >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> Enrico >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> [1] >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>> >>> >>>>>>>>>>> >>> >>>>>>>>>> >>> >>>>>>>>> >>> >>>>>>>> >>> >>>>>>> >>> >>>>> >>> >>> >>> https://builds.apache.org/job/Zookeeper-trunk-single-thread/search/?q=zookeeper&Jenkins-Crumb=1e1a1d3bbc6a541e903422747a16c759 >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>> >>> >>>>>>>>>>> >>> >>>>>>>>>> >>> >>>>>>>>> >>> >>>>>>>> >>> >>>>>>> >>> >>>>> >>> >>>>> >>> >>> >>> >>> >>> > >>> >>>
