Awesome work Enrico! +1 from my side.
+ verify source tarball contains no binary files. + verify binary tarball contains no source files. + locally build by `mvn clean install -DskipTests -Pfull-build)`. + ... and then locally verify by `mvn verify`, tests pass. + start a one quorum cluster and test basic functions like create/delete/set/get, nothing unexpected. Best, tison. Norbert Kalmar <[email protected]> 于2019年9月17日周二 下午10:37写道： > Great, thanks Enrico! > > +1 from my side. > > - source tarball builds(mvn clean install -Pfull-build), tests pass, built > binary runs (tested with simple cli commands). Tarballs are created by > assembly. > - convenience tarball (bin) runs, license files are there. Note: slf4j > api + log4j has one license file, but so did 3.5.5 > > Regards, > Norbert > > > On Mon, Sep 16, 2019 at 11:36 PM Enrico Olivelli <[email protected]> > wrote: > > > This is a bugfix release candidate for 3.5.6. > > > > It fixes 26 issues, including upgrade of third party libraries, > > TTL Node APIs for C API, support for PCKS12 Keystores, and better > procedure > > for the upgrade of servers from 3.4 to 3.5. > > > > The full release notes is available at: > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12345243 > > > > *** Please download, test and vote by September 19th 2019, 23:59 UTC+0. > *** > > > > Source files: > > http://people.apache.org/~eolivelli/zookeeper-3.5.6-candidate-0/ > > > > Maven staging repo: > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1040/ > > > > The release candidate tag in git to be voted upon: release-3.5.6-rc0 > > https://github.com/apache/zookeeper/tree/release-3.5.6-rc0 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > http://www.apache.org/dist/zookeeper/KEYS > > > > Should we release this candidate? > > > > Enrico Olivelli > > >
