Hey guys, While comparing the 3.5.6 package with current 3.6.0 I found a couple of issues tha can e considered blockers for a release. Just formal stuff like licensing.
Please any committer check my patch and let me know, and please cherry pick to branch-3.6 https://github.com/apache/zookeeper/pull/1196 There is no functional impact (I wonder if I could commit this stuff directly): - there is no "LICENSE" file for snappy and for metrics-core - we need to update the copyright year in NOTICE files - we need to copy the Airlift reference from NOTICE in the source root to the NOTICE file reported in the binary package - copy the Java 8 warning from branch-3.5 This is the JIRA https://issues.apache.org/jira/browse/ZOOKEEPER-3668 Best regards Enrico Il giorno sab 28 dic 2019 alle ore 14:29 Enrico Olivelli < [email protected]> ha scritto: > Hi, > We have the last patch that is waiting for review: > https://github.com/apache/zookeeper/pull/1134/ > > https://issues.apache.org/jira/browse/ZOOKEEPER-1112 Add support for C > client for SASL authentication > > It is a very big patch on the C client and it needs careful review and it > is introducing a lot of changes (many LOCs). > Personally I am not able to do a real review of C code and it would need > another committer to be accepted. > > I am sorry, I think it will be a great enhancement and the community will > love it (and Perl/Python bindings will benefit as well), but IMHO it can > wait 3.6.1 or 3.7.0 > We are not in a hurry. > > So if no reviewer chimes in within a couple of days I will postpone that > issue to the next release. > > I am continuing to validate branch-3.6 before sending a formal VOTE > > Cheers and season greetings to every one ! > Enrico >
