David Mollitor created ZOOKEEPER-3676:
-----------------------------------------
Summary: Clean Up TxnLogProposalIterator
Key: ZOOKEEPER-3676
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3676
Project: ZooKeeper
Issue Type: Improvement
Reporter: David Mollitor
Assignee: David Mollitor
* Use JDK Collections.emptyIterator where needed
* The the code manually returns an emptyIterator when an error occurs, but
it's also possible to return an emptyIterator by passing 'null' to the
TxnLogProposalIterator constructor. This is a bit ambiguous... why allow both?
Null values 'suck' so I think it's better to just make sure that emptyIterator
is returned where needed an throw NPE if a 'null' value is passed in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
