Log disk filling up is a pretty easy position to get yourself into. I labelled showstopper because split brain of any type should be a showstopper IMO. Systems base their consistency on the assumption that zookeeper is consistent. If zookeeper loses consistency, everything is broken (fortunately recoverably in our case, but could easily have not been).
-Ivan On Wed, Jan 22, 2020 at 11:29 AM Andor Molnar <[email protected]> wrote: > > Thanks for the heads up Ivan. I need to look into it. > > “…on log disk full” - I think it’s rather a matter of robustness, not a > showstopper bug. > > Andor > > > > > > On 2020. Jan 22., at 11:21, Ivan Kelly <[email protected]> wrote: > > > > We discovered a split brain bug last week, which should probably be > > fixed before any new release. ZOOKEEPER-3701. > > > > -Ivan > > > > On Wed, Jan 22, 2020 at 11:13 AM Andor Molnar <[email protected]> wrote: > >> > >> Makes perfect sense. I just committed both. > >> > >> Thanks, > >> Andor > >> > >> > >> > >>> On 2020. Jan 22., at 6:57, Szalay-Bekő Máté <[email protected]> > >>> wrote: > >>> > >>> Hi Andor, > >>> > >>> Thanks for the efforts, I also think there are some important bugfixes to > >>> release on 3.5. > >>> > >>> I think ZOOKEEPER-3482 would be nice to get in 3.5.7. It is low risk (only > >>> some tests + docs update), but it would improve the documentation about > >>> SASL. We had a few SASL-SSL related questions on the mailing lists > >>> recently, looks like people start to use the SSL feature and it would be > >>> nice for them to have the latest docs. > >>> > >>> I have 2 PRs in it: > >>> - https://github.com/apache/zookeeper/pull/1205 is for branch-3.5, and > >>> - https://github.com/apache/zookeeper/pull/1204 for the master branch. The > >>> later one should also be cherry-picked to branch-3.6. > >>> > >>> Kind regards, > >>> Mate > >>> > >>> On Tue, Jan 21, 2020 at 10:39 PM Enrico Olivelli <[email protected]> > >>> wrote: > >>> > >>>> Thank you Andor > >>>> > >>>> > >>>> Il mar 21 gen 2020, 22:35 Andor Molnar <[email protected]> ha scritto: > >>>> > >>>>> Hi dev folks, > >>>>> > >>>>> We have a few important patches on 3.5, so I'm planning to branch and > >>>>> create rc0 for 3.5.7 tomorrow. > >>>>> > >>>>> Is there anything important in-flight that would be important to wait > >>>>> for and include? > >>>>> > >>>> > >>>> No > >>>> > >>>> Enrico > >>>> > >>>> > >>>>> > >>>>> Regards, > >>>>> Andor > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >> >
