The patch looks good.
I left a comment about the precommit job failing.

I will commit the patch as soon as possible
Thank you

Enrico

Il giorno sab 7 mar 2020 alle ore 13:48 tison <[email protected]> ha scritto:
>
> FYI https://github.com/apache/zookeeper/pull/1279
>
> Intuitively I resolve the direct links issue. For improve sentences or the
> whole page structure, mainly to emphasize which versions are under
> maintenance, we can have a later community discussion.
>
> Best,
> tison.
>
>
> tison <[email protected]> 于2020年3月7日周六 下午7:59写道:
>
> > Thanks for your information. I will look into it now.
> >
> > Best,
> > tison.
> >
> >
> > Enrico Olivelli <[email protected]> 于2020年3月7日周六 下午7:52写道:
> >
> >> Il Sab 7 Mar 2020, 12:51 tison <[email protected]> ha scritto:
> >>
> >> > Hi Enrico,
> >> >
> >> > I've created a corresponding JIRA[1]. I used to think that it should be
> >> > some
> >> > links in apache/zookeeper repo. But I fail to find it.
> >> >
> >> > Where is the entry of download page we should update?
> >> >
> >>
> >> Look to the 'website's branch
> >>
> >> Thank you Tison
> >>
> >>
> >> Enrico
> >>
> >> >
> >> > Best,
> >> > tison.
> >> > [1] https://issues.apache.org/jira/browse/ZOOKEEPER-3746
> >> >
> >> >
> >> > Enrico Olivelli <[email protected]> 于2020年3月7日周六 下午6:59写道:
> >> >
> >> > > Hi,
> >> > > I sent the announcement email for 3.6.0  but it bounced for the
> >> reasons
> >> > > below
> >> > >
> >> > > We have to fix the download page as soon as possible
> >> > >
> >> > > Then I will send a new one and update the procedure with a new
> >> templates.
> >> > >
> >> > > Any volunteer?
> >> > >
> >> > > Enrico
> >> > >
> >> > >
> >> > > ---------- Forwarded message ---------
> >> > > Da: <[email protected]>
> >> > > Date: Sab 7 Mar 2020, 11:49
> >> > > Subject: Returned post for [email protected]
> >> > > To: <[email protected]>
> >> > >
> >> > >
> >> > >
> >> > > Hi! This is the ezmlm program. I'm managing the
> >> > > [email protected] mailing list.
> >> > >
> >> > > I'm sorry, your message (enclosed) was not accepted by the moderator.
> >> > > If the moderator has made any comments, they are shown below.
> >> > >
> >> > > >>>>> -------------------- >>>>>
> >> > > Sorry, but the download page is not acceptable.
> >> > >
> >> > > Whilst the page does provide links to the release artifacts and the
> >> sigs
> >> > > and hashes, these are all indirect links.
> >> > >
> >> > > It is difficult for the user to find the current download, let alone
> >> the
> >> > > corrresponding hashes and sigs that relate to it.
> >> > > How is the user suppose to know which of the following files they
> >> need?
> >> > >
> >> > > apache-zookeeper-3.6.0-bin.tar.gz or apache-zookeeper-3.6.0.tar.gz
> >> > >
> >> > > Or perhaps they need both?
> >> > > (yes, it's obvious to ASF developers, but not all users are familiar
> >> > > with our ways)
> >> > >
> >> > > The page should link directly to the artifact and its related sigs and
> >> > > hashes.
> >> > > Similarly for any links to archived releases.
> >> > >
> >> > > Please fix the download page, check that the links work OK, and
> >> submit a
> >> > > new announce email
> >> > >
> >> > > Thanks.
> >> > > <<<<< -------------------- <<<<<
> >> > >
> >> > >
> >> > >
> >> > >
> >> > > ---------- Forwarded message ----------
> >> > > From: Enrico Olivelli <[email protected]>
> >> > > To: Apache Announce List <[email protected]>, UserZooKeeper <
> >> > > [email protected]>, DevZooKeeper <[email protected]>
> >> > > Cc:
> >> > > Bcc:
> >> > > Date: Thu, 5 Mar 2020 08:34:06 +0100
> >> > > Subject: [ANNOUNCE] Apache ZooKeeper 3.6.0 released
> >> > > The Apache ZooKeeper team is proud to announce Apache ZooKeeper
> >> version
> >> > > 3.6.0.
> >> > >
> >> > > ZooKeeper is a high-performance coordination service for distributed
> >> > > applications. It exposes common services - such as naming,
> >> > > configuration management, synchronization, and group services - in a
> >> > > simple interface so you don't have to write them from scratch. You can
> >> > > use it off-the-shelf to implement consensus, group management, leader
> >> > > election, and presence protocols. And you can build on it for your
> >> > > own, specific needs.
> >> > >
> >> > > For ZooKeeper release details and downloads, visit:
> >> > > https://zookeeper.apache.org/releases.html
> >> > >
> >> > > ZooKeeper 3.6.0 Release Notes are at:
> >> > > https://zookeeper.apache.org/doc/r3.6.0/releasenotes.html
> >> > >
> >> > > We would like to thank the contributors that made the release
> >> possible.
> >> > >
> >> > > Regards,
> >> > >
> >> > > The ZooKeeper Team
> >> > >
> >> >
> >>
> >

Reply via email to