Please check my patch https://github.com/apache/zookeeper/pull/1308
I would like to add it to 3.6.1 before a release Enrico Il giorno ven 27 mar 2020 alle ore 17:55 Enrico Olivelli <eolive...@gmail.com> ha scritto: > > > > Il Ven 27 Mar 2020, 17:43 Jordan Zimmerman <jor...@jordanzimmerman.com> ha > scritto: >> >> Boy - it seems it's a mistake for the JDK to have Record in the java.lang >> package. Putting it in a different package would fix this. I wonder if we >> should file a bug or bring it up on the Amber list? > > > I am following that group. > It was a decision made by intent. They won't change. That class is like > java.lang.Object. > > It is only a source compatibility issue not at runtime. So not a big deal > > Enrico > >> >> -Jordan >> >> > On Mar 27, 2020, at 11:26 AM, Enrico Olivelli <eolive...@gmail.com> wrote: >> > >> > Let me file and INFRA issue and a patch for jute >> > >> > Stay tuned >> > >> > Enrico >> > >> > Il Ven 27 Mar 2020, 17:03 Patrick Hunt <ph...@apache.org> ha scritto: >> > >> >> Confirmed locally with oracle jdk 14 and zk trunk. >> >> >> >> Patrick >> >> >> >> On Fri, Mar 27, 2020 at 6:19 AM Enrico Olivelli <eolive...@gmail.com> >> >> wrote: >> >> >> >>> Il giorno gio 26 mar 2020 alle ore 23:45 Patrick Hunt >> >>> <ph...@apache.org> ha scritto: >> >>>> >> >>>> Seems the new JEP 359 record feature is added to jdk14 as a preview and >> >>>> it's introduced a regression wrt our "Record" >> >>>> https://openjdk.java.net/jeps/359 >> >>>> >> >>>> So two things then - we should disambiguate our Record and see why the >> >>>> jenkins job is not seeing this... odd. >> >>> >> >>> Maybe Jenkins has an early version of JDK14 without records support >> >>> >> >>> having a mvn -v on jenkins will help >> >>> >> >>> Can anyone try locally ? >> >>> You can download the jdk and use it just by unpacking the tar.gz file, >> >>> no need to "install" it >> >>> >> >>> Enrico >> >>> >> >>>> >> >>>> Patrick >> >>>> >> >>>> >> >>>> On Thu, Mar 26, 2020 at 3:26 PM Enrico Olivelli <eolive...@gmail.com> >> >>> wrote: >> >>>> >> >>>>> Patrick >> >>>>> you are right >> >>>>> it looks like it is using "/home/jenkins/tools/java/latest14" >> >>>>> >> >>>>> this is my maven version info: >> >>>>> >> >>>>> [eolivelli@localhost target]$ mvn -v >> >>>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >> >>>>> Maven home: /home/eolivelli/dev/maven >> >>>>> Java version: 14, vendor: AdoptOpenJDK, runtime: >> >>>>> /home/eolivelli/dev/jdk-14+36 >> >>>>> Default locale: en_US, platform encoding: UTF-8 >> >>>>> OS name: "linux", version: "5.5.10-200.fc31.x86_64", arch: "amd64", >> >>>>> family: "unix" >> >>>>> >> >>>>> we should add some "mvn -v" to be executed as a pre build step >> >>>>> >> >>>>> Enrico >> >>>>> >> >>>>> Il giorno gio 26 mar 2020 alle ore 23:22 Patrick Hunt >> >>>>> <ph...@apache.org> ha scritto: >> >>>>>> >> >>>>>> The jenkins job for jdk14 is passing - any ideas why you are seeing >> >>>>>> different? Is the jenkins job setup incorrectly? >> >>>>>> >> >>>>>> >> >>>>> >> >>> >> >> https://builds.apache.org/view/Z/view/ZooKeeper/job/zookeeper-master-maven-jdk14/ >> >>>>>> >> >>>>>> Patrick >> >>>>>> >> >>>>>> >> >>>>>> On Thu, Mar 26, 2020 at 3:13 PM Enrico Olivelli < >> >> eolive...@gmail.com >> >>>> >> >>>>> wrote: >> >>>>>> >> >>>>>>> Hi, >> >>>>>>> it looks like ZK cannot be build on JDK14 due to a small source >> >>>>>>> compatibility issue. >> >>>>>>> The error is below. >> >>>>>>> >> >>>>>>> The fix is trivial, we just only have to explicitly import the >> >> full >> >>>>>>> classname of "Record" >> >>>>>>> >> >>>>>>> Enrico >> >>>>>>> >> >>>>>>> both interface org.apache.jute.Record in org.apache.jute and >> >> class >> >>>>>>> java.lang.Record in java.lang match >> >>>>>>> [ERROR] >> >>>>>>> >> >>>>> >> >>> >> >> /home/eolivelli/dev/zookeeper/zookeeper-jute/target/generated-sources/java/org/apache/zookeeper/proto/GetMaxChildrenResponse.java:25: >> >>>>>>> error: reference to Record is ambiguous >> >>>>>>> [ERROR] public class GetMaxChildrenResponse implements Record { >> >>>>>>> >> >>>>> >> >>> >> >> >>
