Great work Enrico! Thanks a lot! I hope everybody is satisfied with the pace of ZooKeeper releases without drop in the quality. :)
Regards, Andor > On 2020. Apr 30., at 17:05, Enrico Olivelli <eolive...@gmail.com> wrote: > > I'm happy to announce that we have unanimously approved this release. > > There are 7 approving votes, 3 of which are binding: > > - Enrico Olivelli (binding) > - Andor Molnar (binding) > - Patrick Hunt (binding) > - Szalay-Bekő Máté > - Norbert Kalmar > - Matteo Minardi > - Christopher Tubbs > > There are no disapproving votes. > > I will promote the artifacts and complete the release procedure. > > Thanks to every one who contributed to this great release ! > > Enrico Olivelli > > Il giorno gio 30 apr 2020 alle ore 13:26 Andor Molnar <an...@apache.org> ha > scritto: > >> +1 >> >> - verified release notes >> - verified signatures, checksums >> - run unit tests on Mac and Ubuntu (C tests also passed) >> - verified 3-node quorum with and without SSL on both Java 8 and 11 >> - run smoke and latency tests >> >> Andor >> >> >> >> On Thu, 2020-04-23 at 21:31 -0700, Patrick Hunt wrote: >>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eolive...@gmail.com> >>> wrote: >>> >>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar >>>> <nkal...@cloudera.com.invalid> ha scritto: >>>> >>>>> Only thing I found is that the bin has netty-codec-4.1.49 license >>>>> file >>>>> while the jar included is 4.1.48. I think the license version has >>>>> a typo >>>> in >>>>> the bugfix version. Not sure if it's a showstopper. >>>>> >>>> >>>> I don't consider it a showstopper. >>>> >>>> Do you have time to send a fix please ? >>>> This way if we have to roll out a new RC we can pick it up. >>>> >>> >>> Sorry - my bad on that one. >>> >>> I submitted a simple PR to fix it if you want to pull into the other >>> branches or have it ready if a respin is necessary: >>> https://github.com/apache/zookeeper/pull/1333 >>> >>> Patrick >>> >>> >>>> We could anyhow update to 4.1.49.Final >>>> https://netty.io/news/2020/04/22/4-1-49-Final.html >>>> >>>> Enrico >>>> >>>> >>>>> Otherwise LGTM: >>>>> - Signatures OK >>>>> - Compared to git and 3.6.0 >>>>> - Compiled both on Mac (without C client) and Linux (with C >>>>> client) >>>>> - Run tests (from src) and server (from src and bin tarball), >>>>> connect >>>> with >>>>> client and run simple commands >>>>> - Spotbugs and checkstyle passed >>>>> >>>>> Regards, >>>>> Norbert >>>>> >>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté < >>>>> szalay.beko.m...@gmail.com> >>>>> wrote: >>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 >>>>>> using >>>> OpenJDK >>>>>> 8u242 and maven 3.6.0. >>>>>> - all the unit tests passed (both Java and C-client). >>>>>> - I also built and executed unit tests for zkpython >>>>>> - checkstyle and spotbugs passed >>>>>> - apache-rat passed >>>>>> - fatjar built >>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. >>>>>> (using >>>>>> https://github.com/symat/zk-rolling-upgrade-test) >>>>>> >>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli < >>>>>> eolive...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> This is a release candidate for 3.6.1. >>>>>>> >>>>>>> It is a bugfix release and it introduces a few bugfixes and >>>>>>> new >>>>> features >>>>>> in >>>>>>> these areas: >>>>>>> - compatibility with applications built against 3.5 client >>>>>>> libraries >>>>>>> (restored a few non public APIs) >>>>>>> - update Netty to 4.1.48.Final >>>>>>> - ability to pass configuration as file in zkCli for TLS >>>>>>> config >>>>>>> - Add setKeepAlive support for NIOServerCnxn >>>>>>> - Fix server side request throttling >>>>>>> >>>>>>> The full release notes is available at: >>>>>>> >>>>>>> >>>>>>> >>>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764 >>>>>>> *** Please download, test and vote by April 14th 2020, 23:59 >>>>>>> UTC+0. >>>> *** >>>>>>> Source files: >>>>>>> >> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/ >>>>>>> >>>>>>> Maven staging repo: >>>>>>> >>>> >> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/ >>>>>>> The release candidate tag in git to be voted upon: release- >>>>>>> 3.6.1-1 >>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1 >>>>>>> >>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the >>>>>>> release: >>>>>>> https://www.apache.org/dist/zookeeper/KEYS >>>>>>> >>>>>>> The staging version of the website is: >>>>>>> >>>> >> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/ >>>>>>> Should we release this candidate? >>>>>>> >>>>>>> Enrico Olivelli >>>>>>> >> >>
