On Wed, May 6, 2020 at 9:09 AM Enrico Olivelli <eolive...@gmail.com> wrote: > > Il Mer 6 Mag 2020, 14:59 Szalay-Bekő Máté <szalay.beko.m...@gmail.com> ha > scritto: > > > Hello Guys, > > > > I noticed that the following jenkins job always fails on PRs on branch-3.6 > > or master: > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ > > > > The reason is that this job uses ant during the build. > > > > We actually have separate maven-based jenkins PR job that gets triggered > > for PRs on the master branch: > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/ > > < > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/2024/ > > > > > > > And also the Travis-CI seems to execute builds (without tests) using maven > > for each PR. > > > > Don't you think we should disable the > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ job? > > > > If you check the config it should run only for PRs against branch 3.5 > > Btw I see not so much value in it. > But during the release we must ensure that ANT build is working > > I am +1 to dropping it. > I have spent much time in trying to fix it > It did not find any issue for months >
I looked at the config for the job, and it had two separate boxes checked for building PRs. I suspect it was misconfigured. I have unchecked the second box for triggering builds (the checkbox that did not have the branch filter). If that works, I would recommend keeping it, because it's useful for checking PRs for 3.5. If it doesn't, I would advise disabling automatic builds, and just running Jenkins build jobs on-demand to test PRs for 3.5 (which should be fewer over time, as development shifts towards newer branches). > Enrico > > > > Kind regards, > > Mate > >
