> > > If a project depends on a test jar based on junit5 then the project has > to > > upgrade to junit5. > > > Can you explain more?
jUnit 5 has fundamental changes e.g. classes have been moved to different packages, method signatures have changed, some annotation parameters got removed (timeout, expected), it also became modularized, Rules don't exist anymore, etc. If a test class depends on a test jar using jUnit5 obviously jUnit5 must be used. But there is a special case: jUnit5 vintage package is part of jUnit5 and it is basically a jUnit 4.13 with the important change that it shows every class originating from jUnit4 deprecated. It can be used if someone can live together with a large amount of deprecation messages. If there is a given testclass which uses jUnit5 vintage (basically junit4) in a junit5 based jar and we only depend on this vintage based class in our test we are able to use jUnit4. So jUnit5 with the vintage package is quite tolerant with jUnit4 based test, but still motivates towards migration through the deprecation messages. Regards, Tamaas On Thu, Jul 30, 2020 at 7:06 AM Enrico Olivelli <eolive...@gmail.com> wrote: > Il Gio 30 Lug 2020, 01:28 Tamas Penzes <tam...@cloudera.com.invalid> ha > scritto: > > > If a project depends on a test jar based on junit5 then the project has > to > > upgrade to junit5. > > > > Can you explain more? > > > > > With junit5 the tests can stay in junit4 format (using junit-vintage), > but > > then they complain about being deprecated. > > > > If a test depends on another test class using junit5 the test itself must > > be converted. > > > > ZooKeeper is a good candidate to convert first as it is at the bottom of > > the stack and doesn't deliver a test jar yet. > > > > After finishing ZooKeeper I'd volunteer to do the junit5 upgrade in > Curator > > too. > > > > That's awesome, thanks in advance > Enrico > > > > Regards, Tamaas > > > > On Wed, Jul 29, 2020, 23:53 Patrick Hunt <ph...@apache.org> wrote: > > > > > What's the impact of such a change on projects incorporating//depending > > > upon ZK test libraries? Is that still a thing? > > > > > > Patrick > > > > > > On Wed, Jul 29, 2020 at 2:32 PM Tamas Penzes > <tam...@cloudera.com.invalid > > > > > > wrote: > > > > > > > Hi All, > > > > > > > > If you have (a lot of) free time and would like to review my pull > > > request I > > > > would be over the seventh heaven. > > > > It can be found here: https://github.com/apache/zookeeper/pull/1417 > > > > That's the next step of jUnit4 to 5 migration. > > > > > > > > Thanks, Tamaas > > > > > > > > > > -- *Tamás Pénzes* | Software Engineering Manager e. tam...@cloudera.com cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> <https://www.cloudera.com/> ------------------------------
