Hi Tamas, all,
You wrote: > The jUnit tests in zk-contrib and zk-it are never called and they are > not working. Based on this I would not call them blockers for 3.7.0. Okay, noted. I agree. Thank you for migrating all the other modules! You have probably seen my review on your WIP zk-contrib PR; I was also wondering about the number of users of that REST bridge... https://github.com/apache/zookeeper/pull/1388#pullrequestreview-562930766 Cheers, -D Tamas Penzes <tam...@cloudera.com.INVALID> writes: > Hi All, > > Sorry for being slow in answering. The jUnit tests in zk-contrib and zk-it > are never called and they are not working. > Based on this I would not call them blockers for 3.7.0. > > I tried to fix and convert them to jUnit5, but didn't have time to > finish them. > Sadly I'm also very busy nowadays and don't have time to work on them now > either. If someone feels the power to help me out I'd really appreciate it. > > Regards, Tamaas > > On Wed, Jan 6, 2021 at 4:03 PM Szalay-Bekő Máté <szalay.beko.m...@gmail.com> > wrote: > >> Thank you Damien!! :) >> >> One thing came to my mind: there was the larger story of the junit upgrade. >> I'm not sure how we are with that. Is it finished? (@Tamas can you >> summarize the status?) >> I see the parent story is still in progress: >> https://issues.apache.org/jira/browse/ZOOKEEPER-3732 (although the most of >> the work is done already) >> >> Kind regards, >> Mate >> >> On Wed, Jan 6, 2021 at 3:06 PM Andor Molnar <an...@apache.org> wrote: >> >> > Hi Damien, >> > >> > Thanks for volunteering as release manager. This is gonna be good fun. >> > >> > I’m not following the tickets closely, but I remember the discussion >> about >> > deco’ing Java 8 in branch-3.7 and unfortunately we didn’t reached an >> > agreement. >> > >> > Andor >> > >> > >> > >> > >> > > On 2021. Jan 6., at 13:19, Damien Diederen <ddiede...@sinenomine.net> >> > wrote: >> > > >> > > >> > > Greetings, all, >> > > >> > > >> > > Unless someone objects, this is a last call for tickets before I create >> > > branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new >> > > release, aiming for a first candidate in the coming days. >> > > >> > > Besides the tickets mentioned below, are there other patches you would >> > > like to see included in 3.7.0? If not, I will soon start pushing the >> > > open tickets to 3.8.0 in Jira. >> > > >> > > (Of course, my ticket-tagging, Git-branching, or even publishing a >> first >> > > release candidate does not preclude "cherry-picking" further patches.) >> > > >> > > >> > > I already went through (and somewhat cleaned up) these two views: >> > > >> > > * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617 >> > > >> > > * >> > >> https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC >> > > >> > > We have a single remaining blocker, concerning the C client, and it is >> > > not currently marked for 3.7.0: >> > > >> > > * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete >> > > without reading all the payload. >> > > >> > > (It looks nasty, though, so I will try to have a look ASAP.) >> > > >> > > I also hope to get a green light for merging this first iteration of >> > > quota support: >> > > >> > > * ZOOKEEPER-3301: Enforce the quota limit >> > > >> > > https://github.com/apache/zookeeper/pull/934#issuecomment-754882022 >> > > >> > > >> > > What do you think? >> > > >> > > Cheers, >> > > Damien Diederen >> > > >> > > P.-S. — This is my first time as a ZooKeeper release manager, so don't >> > > hesitate to point out any perceived or actual missteps! >> > > >> > > >> > > >> > > Damien Diederen <ddiede...@sinenomine.net> writes: >> > >> Hi Enrico, all, >> > >> >> > >> A Happy New Year! >> > >> >> > >> Yes, I am still willing to take care of 3.7.0. I thought I would >> start >> > >> once 3.5.9 was out, but I suppose there is no reason not to make >> > >> progress in parallel. >> > >> >> > >> I still have to dig into the tracker and sort the list of applicable >> > >> tickets, but was already wondering about the ones below, for which >> pull >> > >> requests are more or less ready. >> > >> >> > >> (I really would like to include the first one, which is just stalled; >> > >> the latter two, which are mine, are perhaps a bit "fresh.") >> > >> >> > >> * ZOOKEEPER-3301:Enforce the quota limit >> > >> https://github.com/apache/zookeeper/pull/934 >> > >> >> > >> * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in >> > >> multi requests >> > >> https://github.com/apache/zookeeper/pull/1559 >> > >> >> > >> * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL >> > >> authentication >> > >> https://github.com/apache/zookeeper/pull/1564 >> > >> >> > >> What do you think? >> > >> >> > >> I'll ping people on the individual PRs. >> > >> >> > >> Cheers, -D >> > >> >> > >> >> > >> >> > >> Enrico Olivelli <eolive...@gmail.com> writes: >> > >>> Hi ZooKeepers, >> > >>> I feel it is time to deliver 3.7.0 to the public. >> > >>> >> > >>> Any volunteer ? >> > >>> Probably Demien, you already told you were available for this release >> > >>> >> > >>> Please also remember that there is a VOTE open for 3.5.9 >> > >>> >> > >>> Best regards and Happy new year >> > >>> Enrico >> > >> > >>
