+1 (binding)
- I built the source code (-Pfull-build) on Ubuntu 18.04.6 using OpenJDK
11.0.14.1 and maven 3.6.0.
- all the Java unit tests passed eventually
- I also built and executed unit tests for zkpython
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed (with some false-positives, see ZOOKEEPER-4510)
- fatjar built
- I executed quick rolling-upgrade smoke tests (using
https://github.com/symat/zk-rolling-upgrade-test):
- rolling upgrade from 3.5.9 to 3.7.1 RC1
- rolling upgrade from 3.6.3 to 3.7.1 RC1
- rolling upgrade from 3.7.0 to 3.7.1 RC1
- rolling upgrade from 3.7.1 RC1 to 3.8.0
Some unit tests failed for me the first time, but succeeded when I run them
one-by-one:
- org.apache.zookeeper.ZKUtilTest
- org.apache.zookeeper.server.ZooKeeperServerMainTest
- org.apache.zookeeper.server.quorum.QuorumPeerMainMultiAddressTest
- org.apache.zookeeper.server.quorum.QuorumPeerMainTest
- org.apache.zookeeper.server.quorum.ReadOnlyModeTest
- org.apache.zookeeper.server.util.RestoreCommittedLogTest
- org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest
(when I tested RC 0, I also had some flaky tests... some of these were
flaky this time too, but not all)
Thanks for preparing the RC!
Best regards,
Máté
On Sat, May 7, 2022 at 5:34 PM Patrick Hunt <ph...@apache.org> wrote:
> +1 xsum/sigs are valid, rat ran clean as did the dep checks. I tested with
> various sized clusters manually and it all ran fine.
>
> Regards,
>
> Patrick
>
> On Sat, May 7, 2022 at 1:01 AM Mohammad Arshad <ars...@apache.org> wrote:
>
> > This is a bug fix release candidate for 3.7.1. It contains 64 fixes.
> >
> > The full release notes is available at:
> >
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12350030
> >
> > *** Please download, test and vote by Monday, 09 May, 2022, 23:59 UTC+0.
> > ***
> >
> > Source files:
> > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.7.1-rc1/
> >
> > Maven staging repo:
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1076
> >
> > The release candidate tag in git to be voted upon: release-3.7.1-1
> > https://github.com/apache/zookeeper/tree/release-3.7.1-1
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> >
> >
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.7.1-rc1/website/index.html
> >
> >
> > Should we release this candidate?
> >
> > Thanks Regards
> > -Arshad
> >
>
