Created a patch for this: https://github.com/apache/zookeeper/pull/2009
Andor On Tue, 2023-06-13 at 10:57 +0200, Andor Molnar wrote: > Awesome. Thanks Enrico! > > I owe you an apology: found an important TLS ticket which is another > low hanging fruit: > > https://issues.apache.org/jira/browse/ZOOKEEPER-4622 > > ZOOKEEPER-4622 Add Netty-TcNative OpenSSL Support > > We've already done this for HBase and I always wanted to port this > back > to ZooKeeper. It's a very cool performance improvement for Linux- > based > installations (or whereever else Netty has OpenSSL support), > unfortunately for ZooKeeper this is only for the server-client stack. > > Let me land this for 3.9.0. > > Andor > > > On Mon, 2023-06-12 at 15:41 +0200, Enrico Olivelli wrote: > > Tests on master branch are passing on JDK20 > > > > Apache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c) > > Maven home: /home/jenkins/tools/maven/apache-maven-3.9.2 > > Java version: 20, vendor: Eclipse Adoptium, runtime: > > /usr/local/asfpackages/java/adoptium-jdk-20+36 > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "linux", version: "4.15.0-206-generic", arch: "amd64", > > family: "unix" > > > > https://ci-hadoop.apache.org/view/ZooKeeper/job/ZooKeeper-Java-EA/113/ > > > > Enrico > > > > Il giorno lun 12 giu 2023 alle ore 15:16 Andor Molnar > > <an...@apache.org> ha scritto: > > > Sure. I've just noticed that the patch has been outstanding for a > > > year > > > now, small and ready to be submitted. > > > > > > Andor > > > > > > > > > > > > On Mon, 2023-06-12 at 14:29 +0200, Enrico Olivelli wrote: > > > > Il giorno lun 12 giu 2023 alle ore 11:13 Andor Molnar > > > > <an...@apache.org> ha scritto: > > > > > I came across the graceful termination patch yesterday. > > > > > Sounds > > > > > like > > > > > important for K8s environments. Enrico, what do you think? > > > > > Looks > > > > > like > > > > > you're not a fan of that. > > > > > > > > > > ZOOKEEPER-4400 Zookeeper not getting Graceful Termination > > > > > > > > > > https://github.com/apache/zookeeper/pull/1898 > > > > > > > > I have taken a look and I have posted some feedback about > > > > renaming > > > > the > > > > configuration flag. > > > > I am not sure that we are in a hurry to commit that patch, we > > > > can > > > > release it with 3.9.1. > > > > > > > > Enrico > > > > > > > > > > > > > Andor > > > > > > > > > > > > > > > > > > > > On Mon, 2023-06-12 at 08:49 +0200, Enrico Olivelli wrote: > > > > > > Il giorno lun 12 giu 2023 alle ore 08:19 Andor Molnar > > > > > > <an...@apache.org> ha scritto: > > > > > > > Hi Kezhu, > > > > > > > > > > > > > > Sure, I'll take a look at the open PRs before cutting > > > > > > > 3.9.0 > > > > > > > from > > > > > > > master. Let's mark these tickets release blockers as you > > > > > > > suggested. > > > > > > > > > > > > > > Any more blockers of 3.9.0 that anyone knows about? > > > > > > > > > > > > No, there are no critical issues at the moment. > > > > > > > > > > > > I will double check on compatibility with the latest JDKs, > > > > > > it > > > > > > is > > > > > > better that when we cut a new major release > > > > > > it works well with the newer JDKs > > > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > > > > Andor > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, 2023-06-11 at 00:41 +0800, Kezhu Wang wrote: > > > > > > > > Hi all, > > > > > > > > > > > > > > > > Sorry for the disruption. > > > > > > > > > > > > > > > > I want to ask if there is any possibility for us to > > > > > > > > include > > > > > > > > [ZOOKEEPER-4471][1] and [ZOOKEEPER-4472][2] in 3.9.0. > > > > > > > > > > > > > > > > ZOOKEEPER-4472 proposed to add `WatcherType.Persistent` > > > > > > > > and > > > > > > > > `WatcherType.PersistentRecursive` to remove > > > > > > > > `AddWatchMode.PERSISTENT` > > > > > > > > and > > > > > > > > `AddWatchMode.PERSISTENT_RECURSIVE` respectively. It is > > > > > > > > a > > > > > > > > complementary to > > > > > > > > [ZOOKEEPER-4466][3] which supports multiple different > > > > > > > > watches > > > > > > > > on > > > > > > > > one > > > > > > > > path > > > > > > > > and was merged to master one month ago. If we don't get > > > > > > > > it to > > > > > > > > 3.9.0, > > > > > > > > it is > > > > > > > > probably impossible for us to merge it to patch > > > > > > > > versions > > > > > > > > of > > > > > > > > 3.9 > > > > > > > > series as > > > > > > > > it touches both server logic and api side. It might be > > > > > > > > strange to > > > > > > > > ship > > > > > > > > ZOOKEEPER-4466 without ZOOKEEPER-4472, as we are going > > > > > > > > to > > > > > > > > support > > > > > > > > different > > > > > > > > watcher types on one path in watching but not all of > > > > > > > > them > > > > > > > > in > > > > > > > > removing. > > > > > > > > > > > > > > > > ZOOKEEPER-4472 relies on ZOOKEEPER-4471 to deliver > > > > > > > > comprehensive > > > > > > > > tests. > > > > > > > > > > > > > > > > I have already sent a [review request][3] to the dev > > > > > > > > mailing > > > > > > > > list. It > > > > > > > > has > > > > > > > > more descriptional information and a real world use > > > > > > > > case > > > > > > > > of ZOOKEEPER-4472. > > > > > > > > > > > > > > > > Look forward to your feedback in either thread! > > > > > > > > > > > > > > > > [1]: > > > > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-4471 > > > > > > > > [2]: > > > > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-4472 > > > > > > > > [3]: > > > > > > > > https://lists.apache.org/thread/m7gxcffsnjy2lm8g52nssfxb6t800o3r > > > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > Kezhu Wang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > Kezhu Wang > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jun 9, 2023 at 6:17 PM Andor Molnar < > > > > > > > > an...@apache.org > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi Enrico, > > > > > > > > > > > > > > > > > > I can take the master cut next week, but let me put > > > > > > > > > together an > > > > > > > > > email > > > > > > > > > about a TLS topic first. I'd like to propose a fix to > > > > > > > > > resolve > > > > > > > > > the > > > > > > > > > problem of FIPS (custome trust manager in ZK) and > > > > > > > > > reverse > > > > > > > > > DNS > > > > > > > > > lookups. > > > > > > > > > I'd like to include it in 3.9.0 and 3.8.2. > > > > > > > > > > > > > > > > > > Andor > > > > > > > > > > > > > > > > > > p.s. Whoever is making a change on the webpage, > > > > > > > > > please > > > > > > > > > remove > > > > > > > > > the > > > > > > > > > 3.8.0 > > > > > > > > > release. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 2023-06-09 at 09:11 +0200, Enrico Olivelli > > > > > > > > > wrote: > > > > > > > > > > Hello ZooKeepers, > > > > > > > > > > I think that it is time to do a round of releases. > > > > > > > > > > > > > > > > > > > > We should cut a release out of the master branch, > > > > > > > > > > 3.9.0 > > > > > > > > > > and > > > > > > > > > > main > > > > > > > > > > cutting a release out of 3.7.x and 3.8.x would be > > > > > > > > > > useful. > > > > > > > > > > > > > > > > > > > > Before cutting the release please ensure that third > > > > > > > > > > party > > > > > > > > > > libraries > > > > > > > > > > are not reported against CVEs > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is the list of the latest releases > > > > > > > > > > https://zookeeper.apache.org/releases.html > > > > > > > > > > > > > > > > > > > > Would anyone volunteer ? > > > > > > > > > > > > > > > > > > > > Enrico
