Thanks guys, we're making good progress. The `branch-3.9` build is also looking pretty good:
https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-multi-branch-build/job/branch-3.9/ Anyone who cannot assign Jira ticket to the right person, please shout, we need to add people to contributors list. Andor On Wed, 2024-09-18 at 11:53 -0500, Andor Molnar wrote: > Thank you Benoit for the heads-up, I started to look into these > patches. Looks like we have a bunch of important (and complex) fixes > that we should get into the upcoming 3.9 release. > > You mentioned ZOOKEEPER-4394 which has fix that has been superseded > by > a super-patch #2152 which will also resolve ZOOKEEPER-4643 and > ZOOKEEPER-4646. > > I added +1 for that and if you agree please close the original PR for > ZOOKEEPER-4394, because we don't need that anymore. > > We also have ZOOKEEPER-4541, but the patch is superseded by #2152 and > #2154. > > I've also found ZOOKEEPER-3023 (flaky test) and and ZOOKEEPER-4712 > which are good candidates for the release. The former will be > resolved > by the above fixes, the latter has another patch #2032. > > I'm trying to do my best, but there're so many open Jira tickets and > pull requests and it's hard to track down what exactly is needed for > this release. > > To wrap I see the following patches are needed and waiting for > reviews: > #2152, #2154 and #2032. > > By committing these we'll be able to close all the above tickets. If > you agree would you please close anything (jira, PR) which is still > open, but not needed anymore. > > Additionally I noticed there're assignees missing from Jiras. Please > shout and ask ZooKeeper PMC to add contributors to the Jira project. > > --> Committers, please help reviewing the above patches. <-- > > Thanks, > > Andor > > > > > On Wed, 2024-09-18 at 13:51 +0200, Benoit Sigoure wrote: > > Hi Andor, > > Would it be possible to merge the fix for ZOOKEEPER-4541 as it's a > > critical > > data corruption bug with ephemeral znodes that multiple > > organizations > > have > > hit recently. > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-4541 > > https://github.com/apache/zookeeper/pull/2154 > > The pull request is pretty much good to go from what I can tell. > > > > It's not clear to me whether this issue also requires > > https://github.com/apache/zookeeper/pull/2152 as there are multiple > > related > > JIRAs such as https://issues.apache.org/jira/browse/ZOOKEEPER-4394 > > > > It would be great if anything to at least pull in the fix for the > > first one > > mentioned above, if not the second one as well. > > > > Thanks in advance. > > > > On Tue, Sep 17, 2024 at 10:44 AM Andor Molnar <an...@apache.org> > > wrote: > > > > > Hi zk folks, > > > > > > I'm going to start releasing 3.9.3 soon, please take a look at > > > the > > > tickets involved in this release: > > > > > > https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12354432 > > > > > > There's only one open item currently: > > > https://issues.apache.org/jira/browse/ZOOKEEPER-4801 > > > > > > which is patch ready: > > > https://github.com/apache/zookeeper/pull/2130 > > > > > > PTAL. > > > > > > Please let me know if you have concerns or anything important > > > missing. > > >