Hi Gowrima, The ZooKeeper committers won't merge a PR until they are satisfied. If contributors do not respond to comments from others, including you, probably the PR won't be merged. It will be as simple as that.
I see you posted one comment so far on pr#2475. I responded that I do not believe it is valid, and explained why. On Fri, Oct 16, 2026 at 9:39 AM Gowrima Jayaramu <[email protected]> wrote: > > Hi Andor, > > Yes, I can review the code, but I am unable to approve the pull request. > > How can I ensure my review comments are addressed before the code is > committed? > > > Thanks, > Gowrima > > On Thu, Oct 15, 2026 at 9:31 AM Andor Molnár <[email protected]> wrote: > > > I’m pretty sure that anybody with GitHub account can review our pull > > requests. > > Please let me know if you face any obstacles. > > > > Andor > > > > > > > > > On Oct 15, 2026, at 11:15, Gowrima Jayaramu <[email protected]> wrote: > > > > > > Hi Andor, > > > > > > Thanks for letting me know. Do I have permission to review the pull > > request? Just checking in case my approval is needed. > > > > > > Best, > > > Gowrima > > > > > > > > > On Thu, Oct 15, 2026 at 8:45 AM Andor Molnár <[email protected]> wrote: > > > Hi Gowrima, > > > > > > Just noticed that Andrew created a new pull request with important C > > client fixes. I’d appreciate your review on the patch if you have a chance. > > > > > > https://github.com/apache/zookeeper/pull/2475 > > > > > > Thanks, > > > > > > Andor > > > > > > > > > > > > > On Oct 14, 2026, at 09:52, Andor Molnár <[email protected]> wrote: > > > > > > > > Awesome news! Welcome aboard Gowrima! > > > > > > > > “two C devs are better one” - ancient saying :) > > > > > > > > I recommend you the same: search for open issues in the C client Jira > > component and pick any which is interesting to you. The more recent reports > > are probably more important, but that’s not a rule. Up to you. > > > > > > > > Feel free to shout here on dev@ list when you open pull request, I’m > > not necessarily notice them immediately through GH notifications. > > > > > > > > Thank you! > > > > > > > > Andor > > > > > > > > > > > > > > > >> On Oct 8, 2026, at 18:52, Gowrima Jayaramu <[email protected]> > > wrote: > > > >> > > > >> I am interested in this as well. I have fixed a couple of issues in > > the C > > > >> client library. > > > >> > > > >> Thank you, > > > >> gowrima > > > >> > > > >> On Thu, Oct 8, 2026 at 2:41 PM Andrew Purtell < > > [email protected]> > > > >> wrote: > > > >> > > > >>> I'll take you up on that offer, if that would work. We use the C > > client at > > > >>> my employer. I'm surprised nobody else from here (Salesforce) has > > > >>> volunteered. Perhaps they don't subscribe or lurk. > > > >>> > > > >>> On Thu, Sep 17, 2026 at 8:10 AM Andor Molnár <[email protected]> > > wrote: > > > >>> > > > >>>> Hi all, > > > >>>> > > > >>>> We’re looking for somebody with C experience and with some free > > time to > > > >>>> actively maintain the ZooKeeper C client library. I’m happy to > > offer my > > > >>> +1 > > > >>>> for committership in exchange. > > > >>>> > > > >>>> Regards, > > > >>>> > > > >>>> Andor > > > >>>> > > > >>>> > > > >>>> > > > >>> > > > >>> -- > > > >>> Best regards, > > > >>> Andrew > > > >>> > > > >>> Robber barons, ketamine cowboys > > > >>> Vulture capital parasites > > > >>> Unearned vanity, silicon sadists > > > >>> Sharks with gluttonous appetites > > > >>> Arrogant halfwits, nepotist failures > > > >>> Trust fund vagrants, indigent kings > > > >>> Culture warriors, gaslight grifters > > > >>> Charlatans with silver tongues > > > >>> - A23, Lunatics > > > >>> > > > > > > > > > > >
