On Thu, Aug 11, 2011 at 3:52 PM, Nicholas Peshek <kb...@mac.com> wrote:
> Every time I go through the source code I find places where we are using > internalObjectID to verify an if an object is unique (We use [NSDictionary > objectForKey:listObject.internalObjectID] in several places). This concerns > me, because we actually write a method into the code to modify it. Should we > really allow setUID: to happen, or should we have a NSNotification set to go > off every time it happens and modify interested dictionaries? > > This normally wouldn't be a problem, but in IRC it's trivial to change your > internalObjectID, leading to leaked objects. > Yeah, it's weird that IRC has no truly consistent identifier for a contact but rather relies on the nick... we don't want to create an AIListContact from scratch when the nick changes, as that would for example disrupt open private messages with the user. Maybe this would be a good case for a variable to do key-value-observer notifications on (rather than making up a brand new notification name)? -Evan
