Looking good so far. After a quick look a few things that strike out at me so far (without listing nit-picky things, like alignment):
Each panel needs a set width and then align the contents according to that width for consistency, as currently its resizing like crazy. The "General" pane is the most obvious offender. Compare it to the actual System Preferences and you'll realise that the SP doesn't resize its width, thus looks a lot more fluid. Found a UI glitch with the Encryption pane. The "Generate" button moves when you constantly toggle the accounts, and then the "Regenerate" button is glued next to the drop-down. I can help out when it comes to aligning stuff properly, if you want. On 20 Dec 2011, at 00:40, Frank D wrote: > I've just pushed my work for the Preferences Redesign > (http://trac.adium.im/wiki/PreferenceRedesign2011). This set of changes has > been partially reviewed by Colin and has support from Evan, Robby, and > probably others. And there's still some work to be done. > > UI work to be done: > - Mouse down effects for selecting a pref pane should be visually better like > darkening the icon as in System Preferences. > - We should add back/forward buttons like in Sys Prefs. > - As well as the click-to-hold menu of all prefpanes like in Sys Prefs. > - Maybe create separate images for "Messages" and "Message Style". > > General todo: > - Default client preferences haven't been moved to their new home in > "General". > - Some controls are shifted from where they should be because of localized > strings. > - AILocalizationControl doesn't know what the window is when adjusting > the pane's controls. > - Using a default larger width for some panes will help. > - This is branched from an old commit and needs to be merged with default. > - Search terms need to be added, improved. > > I made a few improvements to some of the preferences code, but they're > largely untouched aside from rearranging. I'm pretty sure that all > preferences point to their correct settings. > > Changes: > - Search. > - Reorganization of preferences, you can see the changes in this PDF > http://trac.adium.im/attachment/wiki/PreferenceRedesign2011/Adium%20Prefs%20Redux%202.pdf > - Bindings are used for most settings. > - Panes that don't define their AIPreferenceCategory will be put into the > Advanced group. > - Probably some memory management issues since I'm rubbish at that. > > Summary: > - 58 source files changed, 381 total. > - 5 nibs are no longer localized and have been removed. > - Time for other eyes to test and fix. > > > -- > Frank > > >
