> -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Wednesday, April 03, 2019 8:24 PM > To: Wu, Hao A; [email protected] > Cc: Justen, Jordan L; David Woodhouse > Subject: Re: [edk2] [RFC PATCH v1 2/8] OvmfPkg: Copy Legacy8259 protocol > definitions from IntelFrameworkPkg > > On 04/03/19 09:00, Hao Wu wrote: > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496 > > > > This commit copies the exact Legacy8259 protocol header file from > > IntelFrameworkPkg to OvmfPkg. Also, the protocol GUID definition is > > duplicated in the OvmfPkg DEC file. > > > > Cc: Jordan Justen <[email protected]> > > Cc: Laszlo Ersek <[email protected]> > > Cc: Ard Biesheuvel <[email protected]> > > Cc: David Woodhouse <[email protected]> > > Cc: Ray Ni <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Hao Wu <[email protected]> > > --- > > OvmfPkg/OvmfPkg.dec | 3 +- > > OvmfPkg/Include/Protocol/Legacy8259.h | 297 ++++++++++++++++++++ > > 2 files changed, 299 insertions(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > > index e50c6179a2..fb89ebf3ad 100644 > > --- a/OvmfPkg/OvmfPkg.dec > > +++ b/OvmfPkg/OvmfPkg.dec > > @@ -1,7 +1,7 @@ > > ## @file > > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > > # > > -# Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR> > > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions of the > BSD License > > @@ -89,6 +89,7 @@ > > gXenBusProtocolGuid = {0x3d3ca290, 0xb9a5, 0x11e3, > > {0xb7, 0x5d, > 0xb8, 0xac, 0x6f, 0x7d, 0x65, 0xe6}} > > gXenIoProtocolGuid = {0x6efac84f, 0x0ab0, 0x4747, > > {0x81, 0xbe, > 0x85, 0x55, 0x62, 0x59, 0x04, 0x49}} > > gIoMmuAbsentProtocolGuid = {0xf8775d50, 0x8abd, 0x4adf, {0x92, > 0xac, 0x85, 0x3e, 0x51, 0xf6, 0xc8, 0xdc}} > > + gEfiLegacy8259ProtocolGuid = {0x38321dba, 0x4fe0, 0x4e17, {0x8a, > 0xec, 0x41, 0x30, 0x55, 0xea, 0xed, 0xc1}} > > > > [PcdsFixedAtBuild] > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|0x0|UINT32|0 > > (This comment is not about the patch, but your git setup.) > > Please update your git config so that "git format-patch" and its friends > display the INI-style section, such as [Protocols], in the diff hunk > headers. The expected result is: > > @@ -89,6 +89,7 @@ [Protocols] > ^^^^^^^^^^^ > > You can find documentation at: > > - > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git- > guide-for-edk2-contributors-and-maintainers#contrib-05 > (see the 'diff.ini.xfuncname' setting) > > - > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git- > guide-for-edk2-contributors-and-maintainers#contrib-09
Settings are done. Should reflect in the next version of the series (for license change). Best Regards, Hao Wu > > For this patch: > > Reviewed-by: Laszlo Ersek <[email protected]> > > Thanks > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#22): https://edk2.groups.io/g/devel/message/22 Mute This Topic: https://groups.io/mt/30892819/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
