On 04/09/19 03:07, Zhang, Shenglei wrote: > Hi All, > > I'd like to know if you have any comment on this change. > > Thanks, > Shenglei
I reviewed your patch eight (8) days ago. http://mid.mail-archive.com/8ef11c83-27ed-6b0f-9b56-fb628bab1915@redhat.com https://lists.01.org/pipermail/edk2-devel/2019-April/038462.html My review email was addressed to you as well ("Shenglei Zhang <shenglei.zh...@intel.com>"), not just the list. Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Shenglei Zhang >> Sent: Friday, March 29, 2019 9:41 AM >> To: edk2-de...@lists.01.org >> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Laszlo Ersek >> <ler...@redhat.com> >> Subject: [edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove >> dependency on Mps.h >> >> Mps.h is included in BdsPlatform.h but not actually used. >> So remove it. >> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> >> --- >> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> index 4948ca6518..d6dfe1e697 100644 >> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h >> @@ -63,7 +63,6 @@ Abstract: >> >> #include <Guid/Acpi.h> >> #include <Guid/SmBios.h> >> -#include <Guid/Mps.h> >> #include <Guid/HobList.h> >> #include <Guid/GlobalVariable.h> >> #include <Guid/EventGroup.h> >> -- >> 2.18.0.windows.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-de...@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38689): https://edk2.groups.io/g/devel/message/38689 Mute This Topic: https://groups.io/mt/30994367/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
