On 04/10/19 10:39, Jordan Justen wrote: > https://github.com/jljusten/edk2.git temp-ram-support-v2 > > https://github.com/jljusten/edk2/commits/temp-ram-support-v2 > > v2: > * Add AARCH64 and ARM assembly > * Drop IA32 and X64 .S source files > * Adjust PEI_CORE_TEMPORARY_RAM_TRANSITION pointer in the assembly > code based on the stack pointer change before & after > TemporaryRamSupport->TemporaryRamMigration > * Drop extra cleanup patches for OvmfPkg & EmulatorPkg. These were > just complicating the series. > > This series fixes an issue that, while rare, is possible based on the > way the TemporaryRamSupport PPI is defined along with how it is used > by the PEI Core. > > Liu Yu reported a boot issue with EmulatorPkg, which I believe was > caused by this issue. > > The details of the issue are described in the commit message of the > "MdeModulePkg/Core/Pei: Add interface for assembly based > TemporaryRamSupport" patch. > > Testing: > > I tested building and booting in several scenarios: > > * OVMF IA32 & X64 on Linux
Performed my usual Linux checks on these, as described in <https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with-QEMU,-KVM-and-libvirt>. For building, I used the GCC48 toolchain. > * ArmVirtPkg AARCH64 & ARM on x86_64 Linux Performed a normal boot test, on AARCH64 KVM. For building, I used the GCC5 toolchain (using an oldie 6.1.1 cross-compiler from x86_64). For the series, Regression-tested-by: Laszlo Ersek <ler...@redhat.com> If a nontrivial update is needed for the series, I don't mind retesting, but only as the last action before pushing. Testing is time consuming and now I'm asking myself if I should have waited for some feedback to arrive first. :) Thanks Laszlo > * EmulatorPkg IA32 & X64 on Linux > > Untested: > > * My system does not reproduce the issue that Liu Yu reported with > EmulatorPkg, so I can't say that I have verified that issue. > * Building on windows > * AARCH64/ARM TemporaryRamMigration.asm sources > > Cc: Liu Yu <pedroa....@outlook.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Andrew Fish <af...@apple.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Jordan Justen (6): > MdeModulePkg/Core/Pei: Add interface for assembly based > TemporaryRamSupport > MdeModulePkg/Core/Pei: Add AARCH64 assembly for TemporaryRamMigration > MdeModulePkg/Core/Pei: Add ARM assembly for TemporaryRamMigration > MdeModulePkg/Core/Pei: Add IA32 assembly for TemporaryRamMigration > MdeModulePkg/Core/Pei: Add X64 assembly for TemporaryRamMigration > MdeModulePkg/Core/Pei: Use code path for assembly based > TemporaryRamSupport > > .../AArch64/TemporaryRamMigration.S | 63 +++++++++++++++ > .../AArch64/TemporaryRamMigration.asm | 63 +++++++++++++++ > .../Dispatcher/Arm/TemporaryRamMigration.S | 68 ++++++++++++++++ > .../Dispatcher/Arm/TemporaryRamMigration.asm | 68 ++++++++++++++++ > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 59 +++++++++----- > .../Ia32/TemporaryRamMigration.nasm | 77 +++++++++++++++++++ > .../Dispatcher/X64/TemporaryRamMigration.nasm | 74 ++++++++++++++++++ > MdeModulePkg/Core/Pei/PeiMain.h | 52 +++++++++++++ > MdeModulePkg/Core/Pei/PeiMain.inf | 15 ++++ > 9 files changed, 518 insertions(+), 21 deletions(-) > create mode 100644 > MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.S > create mode 100644 > MdeModulePkg/Core/Pei/Dispatcher/AArch64/TemporaryRamMigration.asm > create mode 100644 > MdeModulePkg/Core/Pei/Dispatcher/Arm/TemporaryRamMigration.S > create mode 100644 > MdeModulePkg/Core/Pei/Dispatcher/Arm/TemporaryRamMigration.asm > create mode 100644 > MdeModulePkg/Core/Pei/Dispatcher/Ia32/TemporaryRamMigration.nasm > create mode 100644 > MdeModulePkg/Core/Pei/Dispatcher/X64/TemporaryRamMigration.nasm > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38828): https://edk2.groups.io/g/devel/message/38828 Mute This Topic: https://groups.io/mt/31016921/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
