On Sun, 14 Apr 2019 at 18:25, Wu, Hao A <hao.a...@intel.com> wrote: > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Monday, April 15, 2019 3:52 AM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel; Kinney, Michael D; Andrew Fish; Leif Lindholm; Zeng, > > Star; > > Dong, Eric; Ni, Ray; Gao, Liming; Carsey, Jaben; Shi, Steven; Wang, Jian J; > > Wu, > > Hao A > > Subject: [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign > > arch PE/COFF images > > > > Add the basic plumbing to DXE core, the PCI bus driver and the boot manager > > to allow PE/COFF images to be dispatched that target an architecture that is > > not native for the platform, but which is supported by one of potentially > > several available emulators. > > > > One implementation of such an emulator can be found here: > > https://github.com/ardbiesheuvel/X86EmulatorPkg/tree/upstream-v4 > > > > This also allows us to get rid of the special treatment of EBC images in > > core code. Instead, the EbcDxe driver is augmented with an implementation > > of the EDK2 PE/COFF image emulator protocol so that internal knowledge of > > how EBC is implemented (I-cache flushing, thunks) is removed from the DXE > > core. > > > > Changes since v5: > > - Fix build issues reported by Mike Kinney (#2, #5) > > - Fix CheckPatch.py issue regarding the use of EFI_D_ERROR (#2) [This is > > code > > that is only being moved around but I fixed it nonetheless] > > - Use InstallMultipleProtocolInterfaces() to install the EBC protocol and > > the > > PE/COFF emu protocol at the same time (to simplify/fix the error path) > > (#5) > > - Add Mike's Reviewed-by > > The series looks good to be. > Please help to address the format issues as I replied in 1/7 and 2/7 > patches. > > With those addressed, for the series, > Reviewed-by: Hao Wu <hao.a...@intel.com> >
Thank you Hao I have made the changes you requested, and pushed the series as 174232fa9a90..2e21e8c4b896 Thanks to all for the effort, Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39019): https://edk2.groups.io/g/devel/message/39019 Mute This Topic: https://groups.io/mt/31133139/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-