Zhichao, Thanks for update. Reviewed-by: Jian J Wang <[email protected]>
Jian > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, April 17, 2019 1:57 PM > To: Gao, Zhichao <[email protected]>; Yao, Jiewen > <[email protected]>; [email protected] > Cc: Ye, Ting <[email protected]>; Michael Turner > <[email protected]>; Bret Barkelew > <[email protected]>; Gao, Liming <[email protected]>; Wang, > Jian J <[email protected]> > Subject: RE: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > Resend to the groups.io. > Testcase is update in my branch. And all unit test is passed. > By the way, the new interface is not supported in Runtime phase. > > Thanks, > Zhichao > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Gao, Zhichao > > Sent: Thursday, March 28, 2019 12:05 PM > > To: Yao, Jiewen <[email protected]>; [email protected] > > Cc: Ye, Ting <[email protected]>; Michael Turner > > <[email protected]>; Bret Barkelew > > <[email protected]>; Gang Wei <[email protected]>; Gao, > > Liming <[email protected]> > > Subject: Re: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > > > Sorry for late reply. I have write a very simple test case for these new > > APIs. > > And the test result is as expected. > > Refer to > > https://github.com/ZhichaoGao/edk2/commit/31938b606c6a6a1fdb560e3d0 > > dd4e41a78e1d7e9 > > The section to test VerifyEKUsInPkcs7Signature is refer to > > https://github.com/Microsoft/mu_tiano_plus/tree/release/201808/CryptoP > > kg/UnitTests/VerifyPkcs7EkuUnitTestApp > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: Yao, Jiewen > > > Sent: Monday, March 25, 2019 4:22 PM > > > To: Gao, Zhichao <[email protected]>; [email protected] > > > Cc: Ye, Ting <[email protected]>; Michael Turner > > > <[email protected]>; Bret Barkelew > > > <[email protected]>; Gao, Liming <[email protected]>; > > > Gang Wei <[email protected]> > > > Subject: RE: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > > > > > Hi > > > Would you please describe what unit test has been run for the new API ? > > > > > > > > > > -----Original Message----- > > > > From: edk2-devel [mailto:[email protected]] On Behalf > > > > Of Zhichao Gao > > > > Sent: Monday, March 25, 2019 12:01 PM > > > > To: [email protected] > > > > Cc: Ye, Ting <[email protected]>; Michael Turner > > > > <[email protected]>; Bret Barkelew > > > > <[email protected]>; Gao, Liming <[email protected]>; > > > > Gang Wei <[email protected]> > > > > Subject: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > > > > > > > Add new API to get organization name Add new API > > > > VerifyEKUsInPkcs7Signature Add PKCS1v2 (RSAES-OAEP) support > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Zhichao Gao <[email protected]> > > > > Cc: Ting Ye <[email protected]> > > > > Cc: Gang Wei <[email protected]> > > > > Cc: Wang Jian J <[email protected]> > > > > Cc: Liming Gao <[email protected]> > > > > Cc: Sean Brogan <[email protected]> > > > > Cc: Michael Turner <[email protected]> > > > > Cc: Bret Barkelew <[email protected]> > > > > > > > > Bret Barkelew (6): > > > > CryptoPkg/BaseCryptLib.h: Add new API to get organization name > > > > CryptoPkg/BaseCryptLib: Add new API to get organization name > > > > CryptoPkg/BaseCryptLib.h: Add new API VerifyEKUsInPkcs7Signature > > > > CryptoPkg/BaseCryptLib: Add new API VerifyEKUsInPkcs7Signature > > > > CryptoPkg/BaseCryptLib.h: Add PKCS1v2 (RSAES-OAEP) support. > > > > CryptoPkg/BaseCryptLib: Add PKCS1v2 (RSAES-OAEP) support. > > > > > > > > CryptoPkg/Include/Library/BaseCryptLib.h | 121 ++++- > > > > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 + > > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 +- > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c | 218 +++++++++ > > > > .../Library/BaseCryptLib/Pk/CryptPkcs1OaepNull.c | 61 +++ > > > > .../Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 539 > > > > +++++++++++++++++++++ > > > > .../BaseCryptLib/Pk/CryptPkcs7VerifyEkuRuntime.c | 75 +++ > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 102 +++- > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509Null.c | 32 ++ > > > > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 + > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 + > > > > 11 files changed, 1144 insertions(+), 14 deletions(-) create mode > > > > 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c > > > > create mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1OaepNull.c > > > > create mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c > > > > create mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEkuRuntime.c > > > > > > > > -- > > > > 2.16.2.windows.1 > > > > > > > > _______________________________________________ > > > > edk2-devel mailing list > > > > [email protected] > > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39203): https://edk2.groups.io/g/devel/message/39203 Mute This Topic: https://groups.io/mt/31209096/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
