Ard, Using edk2 and edk2-non-osi as submodules in the edk2-platforms repo does have some advantages. Each branch in edk2-platforms can decide which release/tag/sha is required from dependent repos.
This provides a platform focused view of the EDK II project. If using a release/tag/sha for the dependent repos, the content is effectively being used as read-only content like we do for the OpenSSL submodule. When using the combination of edk2-platforms/master, edk2/master, and edk2-non-osi/master, if changes are made in submodules, then there are some additional complexities that the developer needs to be aware. But this is a workflow that is required to make sure a change in edk2/master does not break any platforms in edk2-platforms/master. I think easily discovering a build break is higher priority. Thanks, Mike > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 24, 2019 6:04 AM > To: Gao, Liming <liming....@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com>; Bi, Dandan > <dandan...@intel.com>; edk2-devel-groups-io > <devel@edk2.groups.io>; Julien Grall > <julien.gr...@arm.com>; Leif Lindholm > <leif.lindh...@linaro.org>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Andrew Fish > <af...@apple.com>; Ni, Ray <ray...@intel.com>; Wang, Jian > J <jian.j.w...@intel.com>; Wu, Hao A > <hao.a...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Steele, Kelly > <kelly.ste...@intel.com>; Sun, Zailiang > <zailiang....@intel.com>; Qian, Yi <yi.q...@intel.com> > Subject: Re: [patch 0/7] Move > BaseUefiTianoCustomDecompressLib from > IntelFrameworkModulePkg to MdeModulePkg > > On Wed, 24 Apr 2019 at 15:02, Gao, Liming > <liming....@intel.com> wrote: > > > > Ard: > > I prefer to keep them as the separate repo. One dummy > Git repo can be introduced to submodule edk2, edk2- > platform, edk2-non-osi, and others. User can use this git > repo to get everything. > > > > That is not really my point. > > A git submodule allows you to store *in* the dependent > repository > which exact commit in the core repository you depend on. > A dummy git > repo does not work the same way. > > > > -----Original Message----- > > > From: Ard Biesheuvel > [mailto:ard.biesheu...@linaro.org] > > > Sent: Wednesday, April 24, 2019 8:48 PM > > > To: Gao, Liming <liming....@intel.com> > > > Cc: Laszlo Ersek <ler...@redhat.com>; Bi, Dandan > <dandan...@intel.com>; edk2-devel-groups-io > <devel@edk2.groups.io>; Julien Grall > > > <julien.gr...@arm.com>; Leif Lindholm > <leif.lindh...@linaro.org>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Andrew Fish > > > <af...@apple.com>; Ni, Ray <ray...@intel.com>; Wang, > Jian J <jian.j.w...@intel.com>; Wu, Hao A > <hao.a...@intel.com>; Kinney, > > > Michael D <michael.d.kin...@intel.com>; Steele, Kelly > <kelly.ste...@intel.com>; Sun, Zailiang > <zailiang....@intel.com>; Qian, Yi > > > <yi.q...@intel.com> > > > Subject: Re: [patch 0/7] Move > BaseUefiTianoCustomDecompressLib from > IntelFrameworkModulePkg to MdeModulePkg > > > > > > On Wed, 24 Apr 2019 at 14:46, Gao, Liming > <liming....@intel.com> wrote: > > > > > > > > > > > > So, we need to consider the combination of edk2 > master + edk2-platform master. When do the incompatible > change in edk2 master, we > > > need to update edk2-platform master together. > > > > > > > > > > Yes, it is either that, or we separate them properly, > by pulling core > > > EDK2 into edk2-platforms as a git submodule. That > way, we can update > > > the upstream commit depended upon instead of assuming > that we are > > > always updated in lockstep. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39515): https://edk2.groups.io/g/devel/message/39515 Mute This Topic: https://groups.io/mt/30896388/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
