On Fri, 26 Apr 2019 at 16:17, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Fri, Apr 26, 2019 at 01:56:54PM +0200, Ard Biesheuvel wrote: > > On Fri, 26 Apr 2019 at 13:16, Leif Lindholm <leif.lindh...@linaro.org> > > wrote: > > > > > > On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > > > > Wire up the new 96boards mezzanine SSDT loading support, and use it > > > > to describe the four GPIO LEDs on the Secure96 mezzanine board. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > > --- > > > > Platform/96Boards/Secure96Dxe/Secure96.asl | 103 > > > > ++++++++++++++++++++ > > > > Platform/96Boards/Secure96Dxe/Secure96Dxe.c | 59 ++++++++++- > > > > Platform/96Boards/Secure96Dxe/Secure96Dxe.inf | 1 + > > > > 3 files changed, 158 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.asl > > > > b/Platform/96Boards/Secure96Dxe/Secure96.asl > > > > new file mode 100644 > > > > index 000000000000..bb9dac462a33 > > > > --- /dev/null > > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.asl > > > > @@ -0,0 +1,103 @@ > > > > +/** @file > > > > + * Copyright (c) 2019, Linaro Limited. All rights reserved. > > > > + * > > > > + * This program and the accompanying materials are licensed and made > > > > + * available under the terms and conditions of the BSD License which > > > > + * accompanies this distribution. The full text of the license may be > > > > + * found at http://opensource.org/licenses/bsd-license.php > > > > + * > > > > + * THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > > > BASIS, > > > > + * WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > > > > + * IMPLIED. > > > > + */ > > > > + > > > > +#include "Secure96.h" > > > > + > > > > +DefinitionBlock ("Secure96.aml", "SSDT", 2, "LINARO", "SECURE96", 1) > > > > +{ > > > > + External (\_SB.LS96.GPIO) > > > > + > > > > + Scope (_SB) > > > > + { > > > > + Device (LD96) > > > > + { > > > > + Name (_HID, "PRP0001") // _HID: Hardware ID > > > > + Name (_UID, 0x00) // _UID: Unique ID > > > > + Name (_DSD, Package () { > > > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > > > > > Surely the above stanza is the most repeated bit of boiler plate in > > > the entire tree? I count 207 instances before this goes in. > > > Can we stick a #define in some common header for this and reuse? > > > ACPI_DSD_UUID? > > > > > > As I said, not required for this patch, but would be worth addressing. > > > > > > > We should add the GUID to MdePkg, given that it occurs in the ACPI spec. > > Yeah. What form would be practically consumable by .asl? >
I think only a CPP macro including the "" is workable in practice. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39644): https://edk2.groups.io/g/devel/message/39644 Mute This Topic: https://groups.io/mt/31341744/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
