Sorry, I didn't notice that. I will fix that and send a new version. Best Regards, Zhiguang Liu
>-----Original Message----- >From: Justen, Jordan L >Sent: Monday, April 29, 2019 12:54 PM >To: Liu, Zhiguang <[email protected]>; [email protected] >Cc: Andrew Fish <[email protected]>; Ni, Ray <[email protected]> >Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Add the second console to >Emulator > >What do you think about this change to the commit message? > >EmulatorPkg: Support a second GOP window > >Two GOP screens will be created if PcdEmuGop is set in >EmulatorPkg.dsc: > >gEmulatorPkgTokenSpaceGuid.PcdEmuGop|L"GOP Window 1!GOP Window >2" > >On 2019-04-28 20:04:25, Zhiguang Liu wrote: >> @@ -51,6 +83,10 @@ BDS_CONSOLE_CONNECT_ENTRY gPlatformConsole[] >= { >> (CONSOLE_OUT | CONSOLE_IN) >> }, >> { >> +(EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath2, >> + (CONSOLE_OUT | CONSOLE_IN) >> + }, >> + { > >The indentation looks wrong on these lines. > >With these fixes: >Reviewed-by: Jordan Justen <[email protected]> > >> NULL, >> 0 >> } -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39738): https://edk2.groups.io/g/devel/message/39738 Mute This Topic: https://groups.io/mt/31379376/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
