On 4/27/19 2:53 AM, Laszlo Ersek wrote: > In edk2, we should spell "#pragma pack(...)" with a space character in > front of the opening parenthesis. Fix up locations that suggest otherwise. > > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Julien Grall <julien.gr...@arm.com> > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > index b354ec6f81c8..aa827ac6aa81 100644 > --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > @@ -596,17 +596,17 @@ STATIC CONST EFI_GUID mMicrosoftOwnerGuid = { > // }; | > // > // Given that the "struct hack" invokes undefined behavior (which is why C99 > // introduced the flexible array member), and because subtracting those pesky > // sizes of 1 is annoying, and because the format is fully specified in the > // UEFI specification, we'll introduce two matching convenience structures > that > // are customized for our X.509 purposes. > // > -#pragma pack(1) > +#pragma pack (1) > typedef struct { > EFI_TIME TimeStamp; > > // > // dwLength covers data below > // > UINT32 dwLength; > UINT16 wRevision; > @@ -627,17 +627,17 @@ typedef struct { > // SignatureSize covers data below > // > EFI_GUID SignatureOwner; > > // > // X.509 certificate follows > // > } REPEATING_HEADER; > -#pragma pack() > +#pragma pack () > > /** > Enroll a set of certificates in a global variable, overwriting it. > > The variable will be rewritten with NV+BS+RT+AT attributes. > > @param[in] VariableName The name of the variable to overwrite. > >
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39764): https://edk2.groups.io/g/devel/message/39764 Mute This Topic: https://groups.io/mt/31359375/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
