> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Monday, April 29, 2019 9:11 PM > To: devel@edk2.groups.io; Gao, Liming <liming....@intel.com> > Subject: Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in > NetworkPkg > > On 04/25/19 14:37, Liming Gao wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 > > BZ 1293 requests to move Network modules from MdeModulePkg to NetworkPkg. > > To keep the backword compatiblity, Network package level include DSC/FDF > > are introduced to be used in the platform DSC/FDF files. When Network > > modules are moved from MdeModulePkg to NetworkPkg, Network package level > > include DSC/FDF will be updated together. There is no impact on the platform > > DSC/FDF file. > > > > This patch set is to introduce network package level include DSC/FDF files. > > Bases on previous discussion and the existing usage case, build flag will be > > used to enable/disable the network features. PCD control feature way can be > > discussed later. And, to meet with the different usages, this patch set > > introduces the separate DSC for Defines/Pcds/Libraries/Components (Patch 2) > > , and also adds the package level combined DSC to include them all (Patch > > 3). > > If platform wants to use the flexible way to enable Network feature, it can > > use the separate DSCs. If the platform wants to directly enable Network > > feature, it can use the combined package DSC file. > > > > This patch set is to update NetworkPkg only. If there is no objection on > > this > > proposal, the following changes to platform DSC/FDF will be made and sent > > for > > review. By default, the platform DSC/FDF will use the combined DSC/FDF file. > > If the platform owner wants to use the flexible way to enable Network > > feature, > > please reply this mail. > > Yes, I'd like both OvmfPkg and ArmVirtPkg platforms to use the > standalone include files from patch #2. Thanks for your message. I will take it. > > As I mentioned in my review of patch #2, the new flags should be > appropriate replacements for OvmfPkg and ArmVirtPkg, out of the box, > except for NETWORK_TLS_ENABLE. OK. I will replace other except for NETWORK_TLS_ENABLE. > > - For ArmVirt, we're going to address TLS_ENABLE separately (see > <https://bugzilla.tianocore.org/show_bug.cgi?id=1009>). > > - In OvmfPkg, we'll keep TLS_ENABLE, and set NETWORK_TLS_ENABLE to FALSE > (see the explanation in my review). > > Thanks! > Laszlo > > > Liming Gao (3): > > NetworkPkg DSC: Add the required ARM library to pass ARM build > > NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. > > NetworkPkg: Add package level include DSC file > > > > NetworkPkg/Network.dsc.inc | 30 +++++++++ > > NetworkPkg/Network.fdf.inc | 56 ++++++++++++++++ > > NetworkPkg/NetworkComponents.dsc.inc | 61 +++++++++++++++++ > > NetworkPkg/NetworkDefines.dsc.inc | 126 > > +++++++++++++++++++++++++++++++++++ > > NetworkPkg/NetworkLibs.dsc.inc | 19 ++++++ > > NetworkPkg/NetworkPcds.dsc.inc | 16 +++++ > > NetworkPkg/NetworkPkg.dsc | 25 +------ > > 7 files changed, 311 insertions(+), 22 deletions(-) > > create mode 100644 NetworkPkg/Network.dsc.inc > > create mode 100644 NetworkPkg/Network.fdf.inc > > create mode 100644 NetworkPkg/NetworkComponents.dsc.inc > > create mode 100644 NetworkPkg/NetworkDefines.dsc.inc > > create mode 100644 NetworkPkg/NetworkLibs.dsc.inc > > create mode 100644 NetworkPkg/NetworkPcds.dsc.inc > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39777): https://edk2.groups.io/g/devel/message/39777 Mute This Topic: https://groups.io/mt/31341792/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
