Thanks for your quick review. I will update and push. > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, May 20, 2019 10:51 PM > To: Gao, Liming <liming....@intel.com> > Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheu...@linaro.org>; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add > NetworkPkg/NetworkPkg.dec as the package dependency > > On Mon, May 20, 2019 at 09:09:47PM +0800, Liming Gao wrote: > > NetLib will be moved from MdeModulePkg and NetworkPkg. > > So, the module that consumes NetLib need to depend on NetworkPkg.dec. > > > > Signed-off-by: Liming Gao <liming....@intel.com> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > --- > > Platform/ARM/Library/BdsLib/BdsLib.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf > > b/Platform/ARM/Library/BdsLib/BdsLib.inf > > index 12995cf174..6b95ec943b 100644 > > --- a/Platform/ARM/Library/BdsLib/BdsLib.inf > > +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf > > @@ -23,6 +23,7 @@ > > MdeModulePkg/MdeModulePkg.dec > > MdePkg/MdePkg.dec > > Platform/ARM/ARM.dec > > + NetworkPkg/NetworkPkg.dec > > If you move that insertion up one line to get it alphabetically > sorted: > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > > > > > [LibraryClasses] > > ArmLib > > -- > > 2.13.0.windows.1 > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41061): https://edk2.groups.io/g/devel/message/41061 Mute This Topic: https://groups.io/mt/31684917/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-