Leif:
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, May 21, 2019 7:59 PM
> To: Zhang, Shenglei <shenglei.zh...@intel.com>
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH edk2-platforms V3 10/18]
> Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF
>
> On Mon, May 20, 2019 at 03:07:21PM +0800, Shenglei Zhang wrote:
> > This patch updates the platform DSC/FDF files to use the include fragment
> > files provided by NetworkPkg.
> >
> > v2: Change Network.dsc.inc to Network.fdf.inc in SynQuacerEvalBoard.fdf.
>
> Any notes on changes go under the "---" line below.
> If you delete this revision comment before committing:
> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
>
I will remove the version in the commit message.
Thanks for your review.
> > Cc: Leif Lindholm <leif.lindh...@linaro.org>
> > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com>
> > ---
> > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +++++--------------
> > .../SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 21 ++---------
> > 2 files changed, 10 insertions(+), 46 deletions(-)
> >
> > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> > index 189baa8659..ab1ab6f2de 100644
> > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> > @@ -22,6 +22,12 @@
> > FLASH_DEFINITION =
> > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
> > BUILD_NUMBER = 1
> >
> > + #
> > + # Network definition
> > + #
> > + DEFINE NETWORK_SNP_ENABLE = FALSE
> > + DEFINE NETWORK_TLS_ENABLE = FALSE
> > +
> > [BuildOptions]
> > RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG -U_FORTIFY_SOURCE
> > -D_FORTIFY_SOURCE=0
> >
> > @@ -49,11 +55,6 @@
> >
> > BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> >
> > - # Networking Requirements
> > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> >
> > # ARM Architectural Libraries
> >
> > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
> > @@ -113,9 +114,6 @@
> >
> > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
> >
> > - HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf
> > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> > -
> > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> >
> > @@ -594,25 +592,8 @@
> > #
> > # Networking stack
> > #
> > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > - NetworkPkg/TcpDxe/TcpDxe.inf
> > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf
> > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
> > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
> > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > - NetworkPkg/IScsiDxe/IScsiDxe.inf
> > - NetworkPkg/DnsDxe/DnsDxe.inf
> > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > - NetworkPkg/HttpDxe/HttpDxe.inf
> > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> > +!include NetworkPkg/Network.dsc.inc
> > +
> > Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf {
> > <LibraryClasses>
> > DmaLib|EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf
> > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
> b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
> > index 1c9795df3b..b1e0a53e61 100644
> > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
> > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
> > @@ -186,25 +186,8 @@ READ_LOCK_STATUS = TRUE
> > #
> > # Networking stack
> > #
> > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > - INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > - INF NetworkPkg/TcpDxe/TcpDxe.inf
> > - INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf
> > - INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
> > - INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
> > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > - INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > - INF NetworkPkg/DnsDxe/DnsDxe.inf
> > - INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > - INF NetworkPkg/HttpDxe/HttpDxe.inf
> > - INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> > +!include NetworkPkg/Network.fdf.inc
> > +
> > INF Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> >
> > #
> > --
> > 2.18.0.windows.1
> >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41127): https://edk2.groups.io/g/devel/message/41127
Mute This Topic: https://groups.io/mt/31682821/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
