The code change looks good for me. But when I try to apply your patch to my local edk2 code, I would encounter an error "error: corrupt patch at line 23". Making sure the patch that can apply to the edk2 trunk is important. Otherwise, the testers and maintainers may take time to write the whole change to their own repo. Most time, it is impossible for them to write the code again because the patches are too many.
Thanks, Zhichao > -----Original Message----- > From: PierreGondois [mailto:pierre.gond...@arm.com] > Sent: Monday, May 20, 2019 9:33 PM > To: devel@edk2.groups.io > Cc: sami.muja...@arm.com; Carsey, Jaben <jaben.car...@intel.com>; Ni, > Ray <ray...@intel.com>; Gao, Zhichao <zhichao....@intel.com>; > matteo.carl...@arm.com; stephanie.hughes-f...@arm.com; n...@arm.com > Subject: [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 > > From: Pierre Gondois <pierre.gond...@arm.com> > > The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual > EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2 > virtual timer fields. > > Signed-off-by: Pierre Gondois <pierre.gond...@arm.com> > --- > > The changes can be seen at: > https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd > ate_v1 > > Notes: > v1: > - GTDT updates for ACPI 6.3 [Pierre] > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > index > 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05 > 7c32369a456267 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > +++ er.c > @@ -5,7 +5,7 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent > > @par Reference(s): > - - ACPI 6.2 Specification - Errata A, September 2017 > + - ACPI 6.3 Specification - January 2019 > **/ > > #include <IndustryStandard/Acpi.h> > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = { > {L"Platform Timer Count", 4, 88, L"%d", NULL, > (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, > {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, > - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} > + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Timer > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} > }; > > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41177): https://edk2.groups.io/g/devel/message/41177 Mute This Topic: https://groups.io/mt/31685310/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
