> -----Original Message----- > From: Gao, Zhichao > Sent: Monday, June 10, 2019 3:29 PM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Sean Brogan; Michael Turner > Subject: [PATCH 1/6] MdeModulePkg/DxeMain: Add performance code
I suggest to change the title to: MdeModulePkg/DxeMain: Add missing PERF_FUNCTION_END for error paths With the change, Reviewed-by: Hao A Wu <hao.a...@intel.com> Best Regards, Hao Wu > > From: Bret Barkelew <bret.barke...@microsoft.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1888 > > Add missing PERF_FUNCTION_END before the return statement. > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Michael Turner <michael.tur...@microsoft.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c > b/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c > index c310b40b52..001a26aa62 100644 > --- a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c > +++ b/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c > @@ -418,6 +418,7 @@ CoreDispatcher ( > // > // If the dispatcher is running don't let it be restarted. > // > + PERF_FUNCTION_END (); > return EFI_ALREADY_STARTED; > } > > @@ -432,6 +433,7 @@ CoreDispatcher ( > &DxeDispatchEvent > ); > if (EFI_ERROR (Status)) { > + PERF_FUNCTION_END (); > return Status; > } > > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42426): https://edk2.groups.io/g/devel/message/42426 Mute This Topic: https://groups.io/mt/32001826/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
