Bob: I think these two C tools are only verified for IA32 and X64 arch OS. They may not work on ARM or AARCH64 OS. Once they are added into BaseTools C Makefile, they may cause compile failure on ARM or AARCH64 OS. So, I suggest to move them into edk2-platforms/Platform/Intel/Tools directory first.
Thanks Liming > -----Original Message----- > From: Feng, Bob C > Sent: Monday, June 17, 2019 5:35 PM > To: Zhang, Shenglei <shenglei.zh...@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <liming....@intel.com> > Subject: RE: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo > > Adding FMMT, FCE to BaseTools is fine for me. > > The patch is good to me. > Reviewed-by: Bob Feng <bob.c.f...@intel.com> > > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, June 11, 2019 1:23 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo > > REF:FMMT(https://bugzilla.tianocore.org/show_bug.cgi?id=1847) > FCE(https://bugzilla.tianocore.org/show_bug.cgi?id=1848) > > Changes are committed in forked repository: > https://github.com/shenglei10/edk2/commits/movetool > > FCE & FMMT tools are in https://firmware.intel.com/develop > Intel UEFI tools and utilities. Now, this patch moves them to edk2 repo > BaseTools directory. Besides, this patch updates their license header > to BSD-2-Clause-Patent, and does some bug fixes. > > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Shenglei Zhang (3): > BaseTools/BfmLib: Add BfmLib to edk2/master > BaseTools/FCE: Add FCE tool to edk2/master > BaseTools/FMMT: Add a new tool FMMT > > BaseTools/Source/C/BfmLib/BfmLib.c | 4355 +++++++++++ > BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 +++ > BaseTools/Source/C/FCE/BinaryCreate.c | 216 + > BaseTools/Source/C/FCE/BinaryParse.c | 1326 ++++ > BaseTools/Source/C/FCE/Common.c | 2183 ++++++ > BaseTools/Source/C/FCE/Expression.c | 2367 ++++++ > BaseTools/Source/C/FCE/Fce.c | 6449 +++++++++++++++++ > BaseTools/Source/C/FCE/IfrParse.c | 4836 ++++++++++++ > .../Source/C/FCE/MonotonicBasedVariable.c | 874 +++ > BaseTools/Source/C/FCE/TimeBasedVariable.c | 878 +++ > BaseTools/Source/C/FCE/Variable.c | 1091 +++ > .../Source/C/FMMT/FirmwareModuleManagement.c | 2559 +++++++ > BaseTools/Source/C/FMMT/FmmtLib.c | 5051 +++++++++++++ > BaseTools/Source/C/FMMT/Rebase.c | 846 +++ > BaseTools/BinWrappers/PosixLike/BfmLib | 29 + > BaseTools/BinWrappers/PosixLike/FCE | 29 + > BaseTools/BinWrappers/PosixLike/FMMT | 29 + > BaseTools/Source/C/BfmLib/BinFileManager.h | 439 ++ > BaseTools/Source/C/BfmLib/GNUmakefile | 15 + > BaseTools/Source/C/BfmLib/Makefile | 17 + > BaseTools/Source/C/FCE/BinaryCreate.h | 157 + > BaseTools/Source/C/FCE/BinaryParse.h | 187 + > BaseTools/Source/C/FCE/Common.h | 999 +++ > BaseTools/Source/C/FCE/Fce.h | 447 ++ > BaseTools/Source/C/FCE/GNUmakefile | 55 + > BaseTools/Source/C/FCE/IfrParse.h | 789 ++ > BaseTools/Source/C/FCE/Makefile | 19 + > .../Source/C/FCE/MonotonicBasedVariable.h | 162 + > BaseTools/Source/C/FCE/TimeBasedVariable.h | 166 + > BaseTools/Source/C/FCE/Variable.h | 154 + > BaseTools/Source/C/FCE/VariableCommon.h | 55 + > .../Source/C/FMMT/FirmwareModuleManagement.h | 479 ++ > BaseTools/Source/C/FMMT/FmmtConf.ini | 6 + > BaseTools/Source/C/FMMT/GNUmakefile | 16 + > BaseTools/Source/C/FMMT/Makefile | 17 + > BaseTools/Source/C/FMMT/Rebase.h | 31 + > BaseTools/Source/C/GNUmakefile | 5 +- > BaseTools/Source/C/Makefile | 5 +- > 38 files changed, 38360 insertions(+), 2 deletions(-) create mode 100644 > BaseTools/Source/C/BfmLib/BfmLib.c > create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c > create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c > create mode 100644 BaseTools/Source/C/FCE/BinaryParse.c > create mode 100644 BaseTools/Source/C/FCE/Common.c create mode 100644 > BaseTools/Source/C/FCE/Expression.c > create mode 100644 BaseTools/Source/C/FCE/Fce.c create mode 100644 > BaseTools/Source/C/FCE/IfrParse.c create mode 100644 > BaseTools/Source/C/FCE/MonotonicBasedVariable.c > create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c > create mode 100644 BaseTools/Source/C/FCE/Variable.c create mode 100644 > BaseTools/Source/C/FMMT/FirmwareModuleManagement.c > create mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c create mode 100644 > BaseTools/Source/C/FMMT/Rebase.c create mode > 100755 BaseTools/BinWrappers/PosixLike/BfmLib > create mode 100755 BaseTools/BinWrappers/PosixLike/FCE > create mode 100755 BaseTools/BinWrappers/PosixLike/FMMT > create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h > create mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile > create mode 100644 BaseTools/Source/C/BfmLib/Makefile > create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h > create mode 100644 BaseTools/Source/C/FCE/BinaryParse.h > create mode 100644 BaseTools/Source/C/FCE/Common.h create mode 100644 > BaseTools/Source/C/FCE/Fce.h create mode 100644 > BaseTools/Source/C/FCE/GNUmakefile > create mode 100644 BaseTools/Source/C/FCE/IfrParse.h create mode 100644 > BaseTools/Source/C/FCE/Makefile create mode 100644 > BaseTools/Source/C/FCE/MonotonicBasedVariable.h > create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h > create mode 100644 BaseTools/Source/C/FCE/Variable.h create mode 100644 > BaseTools/Source/C/FCE/VariableCommon.h > create mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h > create mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini > create mode 100644 BaseTools/Source/C/FMMT/GNUmakefile > create mode 100644 BaseTools/Source/C/FMMT/Makefile create mode 100644 > BaseTools/Source/C/FMMT/Rebase.h > > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42545): https://edk2.groups.io/g/devel/message/42545 Mute This Topic: https://groups.io/mt/32013143/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
