> -----Original Message-----
> From: Dong, Eric
> Sent: Thursday, July 11, 2019 10:22 AM
> To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io
> Cc: Sean Brogan <sean.bro...@microsoft.com>; Ni, Ray <ray...@intel.com>;
> Laszlo Ersek <ler...@redhat.com>; Gao, Liming <liming....@intel.com>;
> Michael Turner <michael.tur...@microsoft.com>; Bret Barkelew
> <bret.barke...@microsoft.com>
> Subject: RE: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol
>
> Hi Zhizhao,
>
> The new add files don't have copyright info, is it ok?
I forgot add file comment for Ia32/EnableInterruptsAndSleep.c. Also lose the
BSD+Patent License. I would add them in the future.
For the copyright:
The code is contributed by Microsoft at
https://github.com/Microsoft/mu_basecore/blob/release/201808/MdePkg/Library/BaseLib/X64/EnableInterrupts.nasm#L48
I move the code from MdePkg to UefiCpuPkg to a single file. It is inappropriate
to add both intel (not contributor) and Microsoft (they didn't add in the above
link).
So I keep the copyright blank. I don't know whether it is ok without copyright.
Hi Liming,
What's your opinion?
Thanks,
Zhichao
>
> Thanks,
> Eric
>
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Tuesday, July 9, 2019 4:40 PM
> > To: devel@edk2.groups.io
> > Cc: Sean Brogan <sean.bro...@microsoft.com>; Dong, Eric
> > <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Laszlo Ersek
> > <ler...@redhat.com>; Gao, Liming <liming....@intel.com>; Michael
> > Turner <michael.tur...@microsoft.com>; Bret Barkelew
> > <bret.barke...@microsoft.com>
> > Subject: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol
> >
> > From: Sean Brogan <sean.bro...@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1400
> >
> > Implement Cp2 protocol: it has one interface to enable the interrupt
> > and put cpu to sleep and wait for an interrupt.
> >
> > Cc: Eric Dong <eric.d...@intel.com>
> > Cc: Ray Ni <ray...@intel.com>
> > Cc: Laszlo Ersek <ler...@redhat.com>
> > Cc: Liming Gao <liming....@intel.com>
> > Cc: Sean Brogan <sean.bro...@microsoft.com>
> > Cc: Michael Turner <michael.tur...@microsoft.com>
> > Cc: Bret Barkelew <bret.barke...@microsoft.com>
> > Signed-off-by: Zhichao Gao <zhichao....@intel.com>
> > ---
> > UefiCpuPkg/CpuDxe/CpuDxe.c | 38 +++++++++++++++++++
> > UefiCpuPkg/CpuDxe/CpuDxe.h | 25 ++++++++++++
> > UefiCpuPkg/CpuDxe/CpuDxe.inf | 3 ++
> > .../CpuDxe/Ia32/EnableInterruptsAndSleep.c | 24 ++++++++++++
> > .../CpuDxe/X64/EnableInterruptsAndSleep.nasm | 31 +++++++++++++++
> > 5 files changed, 121 insertions(+)
> > create mode 100644
> UefiCpuPkg/CpuDxe/Ia32/EnableInterruptsAndSleep.c
> > create mode 100644
> > UefiCpuPkg/CpuDxe/X64/EnableInterruptsAndSleep.nasm
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43549): https://edk2.groups.io/g/devel/message/43549
Mute This Topic: https://groups.io/mt/32403450/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
