Hi Tzy Way,

Nearly there, but please make sure BaseTools/Scripts/PatchCheck.py
runs without warnings or errors (there are quite a few still in this
version).

Building the .dsc using current edk2 fails with
'MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf is not found in packages path'
The path needs to be updated to NetworkPkg/Library/DxeNetLib/DxeNetLib.inf.

Secondly, could you add NOOPT as a BUILD_TARGET, in addition to DEBUG
and RELEASE?

Also, Debian's gcc 8.3 throws a set of compilation errors (both DEBUG
and RELEASE) when building for AARCH64:

/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c:
 In function <E2><80><98>EmacSetupTxdesc<E2><80><99>:
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c:236:81:
 error: iteration 9 invokes undefined behavior 
[-Werror=aggressive-loop-optimizations]
     TxDescriptor->AddrNext = (UINT32)(UINTN)EmacDriver->TxdescRingMap[Index + 
1].AddrMap;
                                             
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c:233:3:
 note: within this loop
   for (Index = 0; Index < CONFIG_TX_DESCR_NUM; Index++) {
   ^~~
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c:
 In function <E2><80><98>EmacSetupRxdesc<E2><80><99>:
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c:270:81:
 error: iteration 9 invokes undefined behavior 
[-Werror=aggressive-loop-optimizations]
     RxDescriptor->AddrNext = (UINT32)(UINTN)EmacDriver->RxdescRingMap[Index + 
1].AddrMap;
                                             
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c:267:3:
 note: within this loop
   for (Index = 0; Index < CONFIG_RX_DESCR_NUM; Index++) {
   ^~~
cc1: all warnings being treated as errors


It also throws the following errors when building for ARM:
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c:
 In function <E2><80><98>SnpTransmit<E2><80><99>:
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c:962:21:
 error: cast to pointer from integer of different size 
[-Werror=int-to-pointer-cast]
   TxDescriptorMap = (VOID *)Snp->MacDriver.TxdescRingMap[DescNum].AddrMap;
                     ^
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c:1026:51:
 error: cast from pointer to integer of different size 
[-Werror=pointer-to-int-cast]
     Snp->RecycledTxBuf[Snp->RecycledTxBufCount] = (UINT64) Data;
                                                   ^
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c:
 In function <E2><80><98>SnpReceive<E2><80><99>:
/work/git/edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c:1143:21:
 error: cast to pointer from integer of different size 
[-Werror=int-to-pointer-cast]
   RxDescriptorMap = (VOID *)Snp->MacDriver.RxdescRingMap[DescNum].AddrMap;
                     ^
cc1: all warnings being treated as errors


Could you please look into and address these issues for the next version?

Best Regards,

Leif

On Mon, Jul 08, 2019 at 03:05:07PM +0800, tzy.way....@intel.com wrote:
> From: Ooi Tzy Way <tzy.way....@intel.com>
> 
> Add driver support for the Ethernet MAC based on Synopsys DesignWare
> 3504-0 Universal 10/100/1000 Ethernet MAC and KSZ9031 PHY
> 
> Cc: Ard BieSheuvel <ard.biesheu...@linaro.org>
> Cc: Leif Lindholm <leif.lindh...@linaro.org>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Cc: Loh Tien Hock <tien.hock....@intel.com>
> 
> Contributed-under: Tianocore Contribution Agreement 1.1
> Signed-off-by: Ooi Tzy Way <tzy.way....@intel.com>
> 
> ---
> v6:
> - Update to recent version for EDK2 specific file formats
> - Update the directory layout to Silicon/Synopsys/DesignWare
> - Add a DesignWare.dsc for building this driver
> - Update the license
> - Update the .c file to declare its own include file
> - Remove __ in defining the header file
> - Fix indentation
> - Delete commented-out code

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43611): https://edk2.groups.io/g/devel/message/43611
Mute This Topic: https://groups.io/mt/32389522/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to