I am anxiously waiting for the review comments. Thanks Ashraf > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed, > Ashraf > Sent: Friday, July 5, 2019 4:42 PM > To: Ni, Ray <ray...@intel.com>; Gao, Liming <liming....@intel.com>; > devel@edk2.groups.io; ler...@redhat.com > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, EFI > encodings to PCI Plat protocol > > Please let me know if this is good enough? > > Thanks > Ashraf > > > -----Original Message----- > > From: Ni, Ray > > Sent: Friday, July 5, 2019 4:02 PM > > To: Javeed, Ashraf <ashraf.jav...@intel.com>; Gao, Liming > > <liming....@intel.com>; devel@edk2.groups.io; ler...@redhat.com > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, > > EFI encodings to PCI Plat protocol > > > > Ashraf, > > Can you please attach the patch in the mail? > > I failed to extract the patch content from the mail. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: Javeed, Ashraf > > > Sent: Friday, July 5, 2019 1:24 PM > > > To: Gao, Liming <liming....@intel.com>; Ni, Ray <ray...@intel.com>; > > > devel@edk2.groups.io; ler...@redhat.com > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, > > > EFI encodings to PCI Plat protocol > > > > > > Hi, > > > Please note that these 2 tags are automatically added when the mail > > > is sent with the formatted patch of the commit.... > > > [edk2-devel] [PATCH] > > > > > > I could add the branch name tag when I sent the commit in the > > > Edk2-staging branch for review with the community - > > > [Edk2-staging\Branch name]. This tags will be preceded with the > > > above > > > 2 tags in the subject line of that mail (too many prefix tags). > > > > > > Can I get Reviewed-By to move this in to the Edk2-staging branch? > > > Please note that this would require a PI Spec update. > > > > > > Thanks > > > Ashraf > > > > > > > -----Original Message----- > > > > From: Gao, Liming > > > > Sent: Friday, July 5, 2019 8:53 AM > > > > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io; > > > > ler...@redhat.com; Javeed, Ashraf <ashraf.jav...@intel.com> > > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New > > > > interface, EFI encodings to PCI Plat protocol > > > > > > > > Ray: > > > > > > > > > -----Original Message----- > > > > > From: Ni, Ray > > > > > Sent: Friday, July 5, 2019 11:14 AM > > > > > To: Gao, Liming <liming....@intel.com>; devel@edk2.groups.io; > > > > > ler...@redhat.com; Javeed, Ashraf <ashraf.jav...@intel.com> > > > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > > > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New > > > > > interface, EFI encodings to PCI Plat protocol > > > > > > > > > > Some unclear parts in the document: > > > > > 1. Document says title begins with "staging/branch". The "branch" > > > > > means the > > > > "branch" word itself > > > > > or should be replaced with a concrete branch name? I prefer > > > > > "branch" > > > word. > > > > Reasons in previous mail. > > > > > NOTE: this affects the individual patch owner. > > > > I understand here is the specific branch name. The patch is > > > > required to be pushed into the specific branch instead of 'branch'. > > > > I think the patch owner should propose which branch to include his > > > > patch. He can propose new branch or use the existing branch. > > > > > > > > > 2. Who owns the staging/master branch sync to edk2/master? > > > > > Document says > > > > the staging/branch is > > > > > based on staging/master but I guess usually staging patch > > > > > owner creates > > > > staging/branch based on edk2/master. > > > > Yes. I think so. > > > > > > > > Thanks > > > > Liming > > > > > > > > > > Thanks, > > > > > Ray > > > > > > > > > > > -----Original Message----- > > > > > > From: Gao, Liming > > > > > > Sent: Friday, July 5, 2019 10:49 AM > > > > > > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io; > > > > > > ler...@redhat.com; Javeed, Ashraf <ashraf.jav...@intel.com> > > > > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > > > > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New > > > > > > interface, EFI encodings to PCI Plat protocol > > > > > > > > > > > > Ray: > > > > > > Yes. Please see https://github.com/tianocore/edk2-staging > > > > > > > > > > > > Thanks > > > > > > Liming > > > > > > >-----Original Message----- > > > > > > >From: Ni, Ray > > > > > > >Sent: Friday, July 05, 2019 10:39 AM > > > > > > >To: Gao, Liming <liming....@intel.com>; devel@edk2.groups.io; > > > > > > >ler...@redhat.com; Javeed, Ashraf <ashraf.jav...@intel.com> > > > > > > >Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > > > > >Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New > > > > > > >interface, EFI encodings to PCI Plat protocol > > > > > > > > > > > > > >Liming, > > > > > > >I understand Laszlo's comment requiring repo name in the > > > > > > >patch title to tell everyone where the code will be. > > > > > > >But before the patch is pushed, the patch owner in theory > > > > > > >cannot guarantee the branch can be successfully created after > > > > > > >the R-b is > > got. > > > > > > >Because someone may create a branch with the same name. > > > > > > > > > > > > > >Is there any public document for the patch which goes to staging > repo? > > > > > > > > > > > > > >Thanks, > > > > > > >Ray > > > > > > > > > > > > > >> -----Original Message----- > > > > > > >> From: Gao, Liming > > > > > > >> Sent: Friday, July 5, 2019 10:13 AM > > > > > > >> To: devel@edk2.groups.io; ler...@redhat.com; Javeed, Ashraf > > > > > > >> <ashraf.jav...@intel.com> > > > > > > >> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Ni, Ray > > > > > > >> <ray...@intel.com> > > > > > > >> Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New > > > > > > >> interface, EFI encodings to PCI Plat protocol > > > > > > >> > > > > > > >> And, please also specify branch name in edk2-staging. > > > > > > >> > > > > > > >> The subject title likes : [PATCH edk2-staging\BranchName] > > > > > > >> [MdePkg/Protocols]: New interface, EFI encodings to PCI > > > > > > >> Plat protocol > > > > > > >> > > > > > > >> >-----Original Message----- > > > > > > >> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > > > > > > >> >On Behalf Of Laszlo Ersek > > > > > > >> >Sent: Friday, July 05, 2019 12:25 AM > > > > > > >> >To: devel@edk2.groups.io; Javeed, Ashraf > > > > > > >> ><ashraf.jav...@intel.com> > > > > > > >> >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, > > > > > > >> >Liming <liming....@intel.com>; Ni, Ray <ray...@intel.com> > > > > > > >> >Subject: Re: [edk2-devel] [PATCH] [MdePkg/Protocols]: New > > > > > > >> >interface, EFI encodings to PCI Plat protocol > > > > > > >> > > > > > > > >> >On 07/04/19 15:20, Javeed, Ashraf wrote: > > > > > > >> >> Please note that this new feature change would be moved > > > > > > >> >> to Edk2-staging > > > > > > >> >after obtaining the Reviewed-By. > > > > > > >> > > > > > > > >> >If the feature targets edk2-staging, then please use the > > > > > > >> >following subject prefix: > > > > > > >> > > > > > > > >> >[PATCH edk2-staging] > > > > > > >> > > > > > > > >> >rather than just > > > > > > >> > > > > > > > >> >[PATCH]. > > > > > > >> > > > > > > > >> >Thanks. > > > > > > >> >Laszlo > > > > > > >> > > > > > > > >> > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43658): https://edk2.groups.io/g/devel/message/43658 Mute This Topic: https://groups.io/mt/32307674/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
