Hello Zhichao, On 07/17/19 09:37, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1907 > > UEFI spec 2.8 introduce a new variable L"RuntimeServicesSupported". > If some runtime sevices is not supported at runtime phase, the variable > should present at boot services. It is a bitmask value, the bit value of > zero indicate the related runtime services is not supported at runtime > phase. > Add the difinition and use it to control Capsule runtime services. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Michael Turner <michael.tur...@microsoft.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > > Zhichao Gao (3): > MdePkg/UefiSpec.h: Add define of runtime services support > MdePkg: Indicate new pcd PcdRuntimeServicesSupport > MdeModulePkg/CapsuleRuntimeDxe: Control runtime services supported
Is a given platform expected to set the new PCD in accordance with other platform settings? Here's why I'm asking. OVMF does not support capsule services, as shown by the following library class resolution in the OVMF DSC files: CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf OVMF will return EFI_UNSUPPORTED when the capsule runtime services are invoked. I'm not sure if the new PCD (and new UEFI variable, "RuntimeServicesSupported") place new requirements on OVMF. It looks like they do. (1) If you agree, can you please include a new patch for OvmfPkg that clears the EFI_RT_SUPPORTED_UPDATE_CAPSULE and RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES bits in the PCD, in all three DSC files? (2) And, the same applies to all three ArmVirtPkg platforms: ArmVirtQemu, ArmVirtQemuKernel, and ArmVirtXen. (3) Furthermore, we already seem to have a related (generic) PCD, namely PcdCapsuleInRamSupport. If that PCD is set to FALSE, then UpdateCapsule() in "MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c" will return EFI_UNSUPPORTED. Should we introduce a consistency check somewhere, between the capsule-related bits of the PcdRuntimeServicesSupport bitmask, and PcdCapsuleInRamSupport? I'm getting confused by the possible interactions between: - PcdRuntimeServicesSupport - PcdCapsuleInRamSupport - and the CapsuleLib class resolution. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43883): https://edk2.groups.io/g/devel/message/43883 Mute This Topic: https://groups.io/mt/32500925/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
