Mike: Yes. I will update this wiki page. Thanks Liming > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, July 19, 2019 11:51 PM > To: Gao, Liming <liming....@intel.com>; devel@edk2.groups.io; Kinney, Michael > D <michael.d.kin...@intel.com> > Cc: Sun, Zailiang <zailiang....@intel.com>; Qian, Yi <yi.q...@intel.com>; > Gary Lin <g...@suse.com> > Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: > Convert use of FCE tool to Structured PCD > > Liming, > > That wiki page does not explain that values are > inherited from STANDARD settings. It only shows > an example use of multiple default stores. > > Mike > > > -----Original Message----- > > From: Gao, Liming > > Sent: Thursday, July 18, 2019 11:41 PM > > To: devel@edk2.groups.io; Kinney, Michael D > > <michael.d.kin...@intel.com> > > Cc: Sun, Zailiang <zailiang....@intel.com>; Qian, Yi > > <yi.q...@intel.com>; Gary Lin <g...@suse.com> > > Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] > > Vlv2TbltDevicePkg: Convert use of FCE tool to Structured > > PCD > > > > Mike: > > Yes. Wiki > > https://github.com/lgao4/edk2/wiki/StructurePcd-Enable- > > Steps shows the usage of the different default store. > > > > >-----Original Message----- > > >From: devel@edk2.groups.io > > [mailto:devel@edk2.groups.io] On Behalf Of > > >Michael D Kinney > > >Sent: Friday, July 19, 2019 2:05 PM > > >To: Gao, Liming <liming....@intel.com>; > > devel@edk2.groups.io; Kinney, > > >Michael D <michael.d.kin...@intel.com> > > >Cc: Sun, Zailiang <zailiang....@intel.com>; Qian, Yi > > ><yi.q...@intel.com>; Gary Lin <g...@suse.com> > > >Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] > > Vlv2TbltDevicePkg: > > >Convert use of FCE tool to Structured PCD > > > > > >Liming, > > > > > >Thanks for the feedback. I have made both changes in > > the V2 version of > > >the series. > > > > > >We should show some examples of inheriting defaults > > from STANDARD > > >defaults. > > > > > >Mike > > > > > >> -----Original Message----- > > >> From: Gao, Liming > > >> Sent: Thursday, July 18, 2019 8:41 PM > > >> To: devel@edk2.groups.io; Kinney, Michael D > > >> <michael.d.kin...@intel.com> > > >> Cc: Sun, Zailiang <zailiang....@intel.com>; Qian, Yi > > >> <yi.q...@intel.com>; Gary Lin <g...@suse.com> > > >> Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] > > >> Vlv2TbltDevicePkg: Convert use of FCE tool to > > Structured PCD > > >> > > >> Mike: > > >> I have two comments here. > > >> 1. VarStore is updated to EfiVarStore. So, > > HiiConfigAccess > > >> ExtractConfig() and RouteConfig() can be updated to > > directly return > > >> UNSUPPORTED, they are not used any more. > > >> 2. DSC doesn't need to include > > PlatformSetupDefaults.dsc twice. By > > >> default, MANUFACTURING setting will be inherited from > > STANDARD. Only > > >> different default setting is required to be > > specified. For your case, > > >> MANUFACTURING default is same to STANDARD. So, you > > only need to > > >> include the default setting for STANDARD only. > > >> > > >> [PcdsDynamicExHii.common.DEFAULT.STANDARD] > > >> !include > > Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > > >> > > >> [PcdsDynamicExHii.common.DEFAULT.MANUFACTURING] # > > can be removed. > > >> !include > > Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > > >> # can be removed. > > >> > > >> Thanks > > >> Liming
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44067): https://edk2.groups.io/g/devel/message/44067 Mute This Topic: https://groups.io/mt/32520522/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
