Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, July 20, 2019 12:43 AM > To: edk2-devel-groups-io <devel@edk2.groups.io> > Cc: Wang, Jian J <jian.j.w...@intel.com>; Ye, Ting <ting...@intel.com> > Subject: [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header > files in INF [Sources] > > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file", > 2019-06-10) logs some (non-fatal) warnings about unlisted internal header > files. List those files explicitly. > > Note: header files are added in lexicographical order only if the > underlying INF file already keeps the [Sources] and [LibraryClasses] > sections in lexicographical order. Otherwise, header files are added in > rough "logical" order. > > Cc: Jian Wang <jian.j.w...@intel.com> > Cc: Ting Ye <ting...@intel.com> > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index 4c4353747622..99dbad23ed5d 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -34,6 +34,7 @@ [Defines] > # > > [Sources] > + InternalCryptLib.h > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index a59079d99e05..0e58d2b5b0ea 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -33,6 +33,7 @@ [Defines] > # > > [Sources] > + InternalCryptLib.h > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index 3fd7d65abfca..c79f2bf4c6c0 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -33,6 +33,7 @@ [Defines] > # > > [Sources] > + InternalCryptLib.h > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > -- > 2.19.1.3.g30247aa5d201 >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44093): https://edk2.groups.io/g/devel/message/44093 Mute This Topic: https://groups.io/mt/32529017/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-