On 07/23/19 02:00, Rebecca Cran wrote: > On 2019-07-22 17:14, Jordan Justen wrote: >> >> I was suggesting that if they didn't specify -n as a param to >> build.sh, then build.sh should not send -n to the edk2 build command. >> The effect would be for the edk2 build command to check >> Conf/target.txt. By default, I think target.txt will not set >> THREADNUMBER, so "0" would still be the result. >> >> Yet, it would give them the option to set it in Conf/target.txt. >> Today, since we always use the -n param, target.txt is always ignored >> for this parameter. > > > On a related topic, I wonder if we should add a "-j" parameter if we > build BaseTools for users (e.g. "make -j4 -C BaseTools")? I've found > that it can be pretty slow without it: on my system adding -j4 reduces > build time from 55 seconds to 15. Going higher doesn't seem to produce > much more benefit: -j32 (on a ThreadRipper system) reduces it to 12 seconds. > >
Passing -j $(getconf _NPROCESSORS_ONLN) to "make" (for building BaseTools) makes sense, IMO. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44219): https://edk2.groups.io/g/devel/message/44219 Mute This Topic: https://groups.io/mt/32553200/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
