On 7/24/19 4:54 AM, Jordan Justen wrote: > On 2019-07-23 18:51:00, wrote: >> Specify the firmware to use via the newer '-drive if=pflash' syntax >> which allows specifying the raw format and readonly parameters. This >> avoids warnings with newer version of QEMU. >> >> Signed-off-by: Rebecca Cran <rebe...@bsdio.com> >> --- >> OvmfPkg/build.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh >> index a2c4eff2a5..e2890ff762 100755 >> --- a/OvmfPkg/build.sh >> +++ b/OvmfPkg/build.sh >> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then >> fi >> ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin >> if [[ "$ENABLE_FLASH" == "yes" ]]; then >> - QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin" >> + QEMU_COMMAND="$QEMU_COMMAND -drive >> if=pflash,format=raw,readonly,file=$QEMU_FIRMWARE_DIR/bios.bin" > > It looks like we set ENABLE_FLASH for qemu 1.6 and newer. Does this > work on 1.6? > > Also, I don't think we want readonly. Read-write should allow > non-volatile variables to persist across multiple boot.
This flash only contains the CODE, not the non-volatile VARS, using readonly makes sense to me. Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44312): https://edk2.groups.io/g/devel/message/44312 Mute This Topic: https://groups.io/mt/32580104/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
