>-----Original Message----- >From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >Sent: Thursday, July 25, 2019 7:12 PM >To: devel@edk2.groups.io; Fan, ZhijuX <zhijux....@intel.com> >Cc: Sean Brogan <spbro...@live.com>; Feng, Bob C <bob.c.f...@intel.com>; >Gao, Liming <liming....@intel.com> >Subject: Re: [edk2-devel] [PATCH V2] BaseTools: replace the chinese >quotation mark with unicode " > >On 7/25/19 5:00 AM, Fan, ZhijuX wrote: >> From: Sean Brogan <spbro...@live.com> >> >> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013 >> >> chinese quotation mark are used in the file >> This patch is going to fix that issue. >> >> Cc: Bob Feng <bob.c.f...@intel.com> >> Cc: Liming Gao <liming....@intel.com> >> Signed-off-by: Zhiju.Fan <zhijux....@intel.com> >> --- >> BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/BaseTools/Source/Python/Pkcs7Sign/Readme.md >b/BaseTools/Source/Python/Pkcs7Sign/Readme.md >> index 5315b7fca4..a7b9caf52c 100644 >> --- a/BaseTools/Source/Python/Pkcs7Sign/Readme.md >> +++ b/BaseTools/Source/Python/Pkcs7Sign/Readme.md >> @@ -10,7 +10,7 @@ NOTE: Below steps are required for Windows. Linux >may already have the OPENSSL e >> set OPENSSL_HOME=c:\home\openssl\openssl-[version] >> set OPENSSL_CONF=%OPENSSL_HOME%\apps\openssl.cnf >> >> -When a user uses OpenSSL (req or ca command) to generate the >certificates, OpenSSL will use the openssl.cnf file as the configuration data >(can use “-config path/to/openssl.cnf” to describe the specific config file). >> +When a user uses OpenSSL (req or ca command) to generate the >certificates, OpenSSL will use the openssl.cnf file as the configuration data >(can use "-config path/to/openssl.cnf" to describe the specific config file). >> >> The user need check the openssl.cnf file, to find your CA path setting, e.g. >check if the path exists in [ CA_default ] section. >> > >I wonder, we could add a BaseTool script as pre-commit hook to check >this kind of easy typos... > >Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
Reviewed-by: Liming Gao <liming....@intel.com> Thanks Liming -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44439): https://edk2.groups.io/g/devel/message/44439 Mute This Topic: https://groups.io/mt/32594579/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
