PatchCheck reports Trailing whitespace. Please fix it when you push the change.
* Trailing whitespace found File: MdeModulePkg/MdeModulePkg.dec Line: # @Prompt Enable 5-Level Paging support in long mode. * Trailing whitespace found File: MdeModulePkg/MdeModulePkg.uni Line: Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, >Hao A >Sent: Thursday, August 08, 2019 1:30 PM >To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io >Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@redhat.com>; >Wang, Jian J <jian.j.w...@intel.com> >Subject: Re: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce >PCD PcdUse5LevelPageTable > >> -----Original Message----- >> From: Ni, Ray >> Sent: Thursday, August 01, 2019 5:58 PM >> To: devel@edk2.groups.io >> Cc: Dong, Eric; Laszlo Ersek; Wu, Hao A; Wang, Jian J >> Subject: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD >> PcdUse5LevelPageTable >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 >> >> The PCD indicates if 5-Level Paging will be enabled in long mode. >> 5-Level Paging will not be enabled when the PCD is TRUE but CPU >> doesn't support 5-Level Paging. >> >> Signed-off-by: Ray Ni <ray...@intel.com> >> Cc: Eric Dong <eric.d...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Hao A Wu <hao.a...@intel.com> >> Cc: Jian J Wang <jian.j.w...@intel.com> >> --- >> MdeModulePkg/MdeModulePkg.dec | 7 +++++++ >> MdeModulePkg/MdeModulePkg.uni | 8 ++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec >> index 12e0bbf579..21388595a9 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -1991,6 +1991,13 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> PcdsDynamic, PcdsDynamicEx] >> # @Prompt The address mask when memory encryption is enabled. >> >> >gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrM >> ask|0x0|UINT64|0x30001047 >> >> + ## Indicates if 5-Level Paging will be enabled in long mode. 5-Level >> Paging >> will not be enabled >> + # when the PCD is TRUE but CPU doesn't support 5-Level Paging. >> + # TRUE - 5-Level Paging will be enabled.<BR> >> + # FALSE - 5-Level Paging will not be enabled.<BR> >> + # @Prompt Enable 5-Level Paging support in long mode. >> + >> >gEfiMdeModulePkgTokenSpaceGuid.PcdUse5LevelPageTable|FALSE|BOOLE >> AN|0x0001105F >> + >> ## Capsule In Ram is to use memory to deliver the capsules that will be >> processed after system >> # reset.<BR><BR> >> # This PCD indicates if the Capsule In Ram is supported.<BR> >> diff --git a/MdeModulePkg/MdeModulePkg.uni >> b/MdeModulePkg/MdeModulePkg.uni >> index 2bd1ad29f2..3a1c88e4c5 100644 >> --- a/MdeModulePkg/MdeModulePkg.uni >> +++ b/MdeModulePkg/MdeModulePkg.uni >> @@ -1298,3 +1298,11 @@ >> >> "It is used to set VPD region base >> address. So, it can't be DynamicExVpd PCD. Its value is" >> >> "required to be accessed in >PcdDxe >> driver entry point. So, its value must be set in PEI phase." >> >> "It can't depend on EFI variable >> service, and can't be DynamicExHii PCD." >> + >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_PROMP >> T #language en-US "Enable 5-Level Paging support in long mode" >> + >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_HELP >> #language en-US "Indicates if 5-Level Paging will be enabled in long mode. 5- >> Level Paging will not be enabled" >> + >> "when the PCD is TRUE but CPU >> doesn't support 5-Level Paging." >> + >> " TRUE - 5-Level Paging will be >> enabled." >> + >> " FALSE - 5-Level Paging will not >be >> enabled." >> + > > >Reviewed-by: Hao A Wu <hao.a...@intel.com> > >Best Regards, >Hao Wu > > >> -- >> 2.21.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45116): https://edk2.groups.io/g/devel/message/45116 Mute This Topic: https://groups.io/mt/32677230/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
