Eric: I review this patch set. I think patch 14 can be merged into patch 4, patch 13 can be merged into patch 5.
And, patch 2 introduces new APIs in FmpDeviceLib. I see edk2-platform Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLib is the FmpDeviceLib library instance. Have you the patch to update it to support new APIs? Last, ECC reports some issues. Please make sure they be fixed in next version. "All include file contents should be guarded by a #ifndef statement.",FmpDevicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.h,1,"" FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c,71,"in Comment, <@param[in, out]> does NOT have [out] " FmpDevicePkg\Include\Library\FmpDeviceLib.h,107,"in Comment, <@param[in, out]> does NOT have [out] " FmpDevicePkg\FmpDxe\FmpDxe.c,202,"No doxygen tags in comment " FmpDevicePkg\FmpDxe\FmpDxe.c,261,"No doxygen tags in comment " Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dandan Bi >Sent: Tuesday, August 06, 2019 4:11 PM >To: devel@edk2.groups.io; Jin, Eric <eric....@intel.com> >Subject: Re: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solution > >Hi Eric, > >This patch series also can be consolidated to a smaller patch set. >Please help double check. > > >Thanks, >Dandan > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Eric Jin >> Sent: Thursday, August 1, 2019 4:39 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solution >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 >> >> The patch set is to support drivers that manage multiple controllers and also >> provide a firmware update capability to each managed controller. >> >> The following modules are related to Multiple Controllers Support solution >> >> FmpDevicePkg\FmpDxe\FmpDxe.inf - Driver to manage multiple controllers >> and provide the firmware update capability to each managed controller. >> FmpDevicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.inf - >> Driver to produce the Capsule Update Policy Protocol using the services of >> the CapsuleUpdatePolicyLib class. The protocol is a private interface to the >> FmpDevicePkg >> >FmpDevicePkg\Library\CapsuleUpdatePolicyLibOnProtocol\CapsuleUpdateP >> olicyLibOnProtocol.inf - CapsuleUpdatePolicyLib instance that uses the >> services of the Capsule Update Policy Protocol produced by >> CapsuleUpdatePolicyDxe >> FmpDevicePkg\Library\CapsuleUpdatePolicyLibNull\CapsuleUpdatePolicyLib >> Null.inf - Null CapsuleUpdatePolicyLib instance and the template for >platform >> specific implementation >> FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLibNull.inf - Null >> FmpDeviceLib instance and the template for platform specific >> implementation >> >> >> Eric Jin (14): >> FmpDevicePkg: Add UEFI_DRIVER support >> FmpDevicePkg: Add APIs to FmpDeviceLib >> FmpDEvicePkg/FmpDeviceLibNull: Implement new APIs >> FmpDevicePkg/FmpDxe: Use new FmpDeviceLib APIs >> FmpDevicePkg/FmpDxe: Different variable for each FMP Descriptor >> FmpDevicePkg: Add Capsule Update Policy Protocol >> FmpDevicePkg/FmpDxe: Improve all DEBUG() messages >> FmpDevicePkg/FmpDxe: Add PcdFmpDeviceImageTypeIdGuid >> FmpDevicePkg/FmpDxe: Add PcdFmpDeviceStorageAccessEnable >> FmpDevicePkg/FmpDxe: Remove use of CatSprint() >> FmpDevicePkg/FmpDxe: Fix SetLowestSupportedVersionInVariable() >> FmpDevicePkg/FmpDxe: Change where FmpControllerState is updated >> FmpDevicePkg/FmpDxe: Fix code indent >> FmpDevicePkg/FmpDxe: Add FmpDxe.h to [Sources] >> >> .../CapsuleUpdatePolicyDxe.c | 173 ++++ >> .../CapsuleUpdatePolicyDxe.h | 135 +++ >> .../CapsuleUpdatePolicyDxe.inf | 48 + >> .../CapsuleUpdatePolicyDxe.uni | 14 + >> .../CapsuleUpdatePolicyDxeExtra.uni | 14 + >> FmpDevicePkg/FmpDevicePkg.dec | 43 +- >> FmpDevicePkg/FmpDevicePkg.dsc | 64 +- >> FmpDevicePkg/FmpDevicePkg.uni | 16 +- >> FmpDevicePkg/FmpDxe/DetectTestKey.c | 16 +- >> FmpDevicePkg/FmpDxe/FmpDxe.c | 787 ++++++++++------ >> FmpDevicePkg/FmpDxe/FmpDxe.h | 355 ++++++++ >> FmpDevicePkg/FmpDxe/FmpDxe.inf | 7 +- >> FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 7 +- >> FmpDevicePkg/FmpDxe/VariableSupport.c | 844 +++++++++++++----- >> FmpDevicePkg/FmpDxe/VariableSupport.h | 135 ++- >> FmpDevicePkg/Include/Library/FmpDeviceLib.h | 104 ++- >> .../CapsuleUpdatePolicyLibOnProtocol.c | 171 ++++ >> .../CapsuleUpdatePolicyLibOnProtocol.inf | 40 + >> .../CapsuleUpdatePolicyLibOnProtocol.uni | 15 + >> .../Library/FmpDeviceLibNull/FmpDeviceLib.c | 93 +- >> .../FmpDeviceLibNull/FmpDeviceLibNull.inf | 4 +- >> .../FmpPayloadHeaderLibV1.inf | 4 +- >> .../Library/FmpPayloadHeaderLib.h | 0 >> .../Protocol/CapsuleUpdatePolicy.h | 132 +++ >> 24 files changed, 2635 insertions(+), 586 deletions(-) >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.h >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.uni >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxeExtra.uni >> create mode 100644 FmpDevicePkg/FmpDxe/FmpDxe.h >> create mode 100644 >> >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >> olicyLibOnProtocol.c >> create mode 100644 >> >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >> olicyLibOnProtocol.inf >> create mode 100644 >> >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >> olicyLibOnProtocol.uni >> rename FmpDevicePkg/{Include => >> PrivateInclude}/Library/FmpPayloadHeaderLib.h (100%) >> create mode 100644 >> FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h >> >> -- >> 2.20.1.windows.1 >> >> >> > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45145): https://edk2.groups.io/g/devel/message/45145 Mute This Topic: https://groups.io/mt/32676808/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
