On 08/08/19 11:55, Leif Lindholm wrote: > Hi Shenglei, > > On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote: >> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35 >> in tools_def.template. These tool chains are for ARM and AARCH64 only. >> There is no change recently and they are not used. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1750 > > This still does not address my comment in the BZ that deleting all > RVCT profiles before full VS support is enabled for (32-bit) ARM, we > orphan an awful lot of .asm files. > > This may not have much of a practical effect, since I doubt anyone is > using these toolchains today - but it does prevent someone from > actively going through and testing future updates (where before, they > may just have neglected to do so). > > This point needs discussing rather than ignoring, and I think we're > getting too close to the freeze to consider the patch to go in as is > at this point. > > Whenever this patch does go in should be in the week after a stable > tag is made, to give plenty of time for anyone affected to shout > before the next stable tag is made. > > After the 2019.08 stable tag has been made, I am happy for a patch > going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.
Tacking on a small technicality: this should be implemented with at least three patches in a series (one per toolchain removed), and each subject line should identify the toolchain being removed. The current subject line is too generic. Thanks Laszlo > The deletion of the final RVCT profile needs further discussion. > > Best Regards, > > Leif > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45229): https://edk2.groups.io/g/devel/message/45229 Mute This Topic: https://groups.io/mt/32796423/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
