On 08/12/19 15:49, Laszlo Ersek wrote: > Hi, > > On 08/12/19 05:07, Zhichao Gao wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 >> >> ResetUtilityLib would be consumed by CapsuleRuntimeDxe. >> So add it for the platform dsc file. >> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Cc: Leif Lindholm <leif.lindh...@linaro.org> >> Cc: Liming Gao <liming....@intel.com> >> Signed-off-by: Zhichao Gao <zhichao....@intel.com> >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index 7ae6702ac1f0..4b8130f8e7fe 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -73,6 +73,7 @@ [LibraryClasses.common] >> >> PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >> >> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >> + ResetUtilityLib|MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf >> >> [LibraryClasses.common.PEIM] >> >> ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf >> > > thanks for updating your git config; these patches are a lot easier to read. > > Under ArmVirtPkg, there are three platform DSC files that include > CapsuleRuntimeDxe: > > - ArmVirtPkg/ArmVirtQemu.dsc > - ArmVirtPkg/ArmVirtQemuKernel.dsc > - ArmVirtPkg/ArmVirtXen.dsc > > In this v4 patch series, the last platform above doesn't seem to be updated. > > I suggest dropping patches #3 and #4 from the v4 series, and adding a > single patch that modifies "ArmVirtPkg/ArmVirt.dsc.inc".
When you update "ArmVirtPkg/ArmVirt.dsc.inc", please add the new ResetUtilityLib class resolution just under the ResetSystemLib resolution. (That one is also part of [LibraryClasses.common].) Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45437): https://edk2.groups.io/g/devel/message/45437 Mute This Topic: https://groups.io/mt/32836894/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
